Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.h

Issue 12314164: Modified Omnibox extension api to use JSON Schema Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_api.h
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.h b/chrome/browser/extensions/api/omnibox/omnibox_api.h
index 5c05302d739b94e3507a6b67cd8c04236b2839aa..f177199459459854b914734a331cc00a85bc57e0 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_api.h
+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.h
@@ -15,6 +15,7 @@
#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
#include "chrome/browser/extensions/extension_function.h"
#include "chrome/browser/extensions/extension_icon_manager.h"
+#include "chrome/common/extensions/api/omnibox.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -36,6 +37,8 @@ class Image;
namespace extensions {
+namespace SetDefaultSuggestion = api::omnibox::SetDefaultSuggestion;
Devlin 2013/02/27 22:14:17 Don't set a namespace like this in the .h file (us
Aaron Jacobs 2013/02/27 23:01:58 Done.
+
// Event router class for events related to the omnibox API.
class ExtensionOmniboxEventRouter {
public:
@@ -151,6 +154,11 @@ struct ExtensionOmniboxSuggestion {
// default suggestions.
bool Populate(const base::DictionaryValue& value, bool require_content);
+ // Populate a suggestion value from Suggestion generated by JSON schema
+ // compiler (only sets the value of the description)
Devlin 2013/02/27 22:14:17 Comments should always be grammatically correct (i
Aaron Jacobs 2013/02/27 23:01:58 Done.
+ bool PopulateFromSuggestion(
+ const SetDefaultSuggestion::Params::Suggestion& suggestion);
+
// Converts a list of style ranges from the extension into the format expected
// by the autocomplete system.
bool ReadStylesFromValue(const base::ListValue& value);

Powered by Google App Engine
This is Rietveld 408576698