Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 12314152: Miscellaneous profile-driven Isolate plumbing. (Closed)

Created:
7 years, 9 months ago by Sven Panne
Modified:
7 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Miscellaneous profile-driven Isolate plumbing. While doing this, it became clear that quite a few functions should not be static and should better live in various classes as instance methods, but I'll leave this for a later CL. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -51 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/d8.cc View 12 chunks +31 lines, -20 lines 0 comments Download
M src/deoptimizer.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopeinfo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 9 months ago (2013-02-27 14:33:24 UTC) #1
Michael Starzinger
LGTM, and not a single nit was given. :)
7 years, 9 months ago (2013-02-27 14:44:23 UTC) #2
Sven Panne
7 years, 9 months ago (2013-02-27 14:46:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13765 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698