Make sure the socket unsubscribes on error, so we don't get race conditions between an error and an…

runtime/bin/socket_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class RawServerSocket  {
   /* patch */ static Future<RawServerSocket> bind([String address = "127.0.0.1",
                                                    int port = 0,
                                                    int backlog = 0]) {
     return _RawServerSocket.bind(address, port, backlog);
   }
@@ skipping 641 matching lines @@
   StreamSubscription subscription;
   final _Socket socket;
   int offset;
   List<int> buffer;
   bool paused = false;
 
   _SocketStreamConsumer(this.socket);
 
   Future<Socket> consume(Stream<List<int>> stream) {
     if (socket._raw != null) {
-      subscription = stream.listen((data) {
-        assert(!paused);
-        assert(buffer == null);
-        buffer = data;
-        offset = 0;
-        write();
-      },
-      onError: (error) {
-        socket._consumerDone(error);
-      },
-      onDone: () {
-        socket._consumerDone();
-      });
+      subscription = stream.listen(
+          (data) {
+            assert(!paused);
+            assert(buffer == null);
+            buffer = data;
+            offset = 0;
+            write();
+          },
+          onError: (error) {
+            socket._consumerDone(error);
+          },
+          onDone: () {
+            socket._consumerDone();
+          },
+          unsubscribeOnError: true);
     }
     return socket._doneFuture;
   }
 
   void write() {
     try {
       if (subscription == null) return;
       assert(buffer != null);
       // Write as much as possible.
       offset += socket._write(buffer, offset, buffer.length - offset);
@@ skipping 234 matching lines @@
     _raw.onBadCertificate = callback;
   }
 
   X509Certificate get peerCertificate {
     if (_raw == null) {
      throw new StateError("peerCertificate called on destroyed SecureSocket");
     }
     return _raw.peerCertificate;
   }
 }