Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 12314132: Fix bad optimization prematurely marking types as instantiated (issue 8710). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
===================================================================
--- runtime/vm/class_finalizer.cc (revision 19100)
+++ runtime/vm/class_finalizer.cc (working copy)
@@ -771,11 +771,7 @@
// Self referencing types may get finalized indirectly.
if (!parameterized_type.IsFinalized()) {
// Mark the type as finalized.
- if (parameterized_type.IsInstantiated()) {
- parameterized_type.set_is_finalized_instantiated();
- } else {
- parameterized_type.set_is_finalized_uninstantiated();
- }
+ parameterized_type.SetIsFinalized();
}
// Upper bounds of the finalized type arguments are only verified in checked
@@ -1632,7 +1628,7 @@
}
ASSERT(type.HasResolvedTypeClass());
if (!type.IsFinalized()) {
- type.set_is_finalized_instantiated();
+ type.SetIsFinalized();
// Do not canonicalize malformed types, since they may not be resolved.
} else {
// The only case where the malformed type was already finalized is when its
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698