Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4277)

Unified Diff: chrome/installer/util/installer_state_unittest.cc

Issue 12314090: Add utf_string_conversions to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/installer_state.cc ('k') | chrome/installer/util/logging_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/installer_state_unittest.cc
diff --git a/chrome/installer/util/installer_state_unittest.cc b/chrome/installer/util/installer_state_unittest.cc
index 5395a8492cc298b58468bab48f9bcec707520008..ca64c973435827db316fcb0d0487865c9c27dd04 100644
--- a/chrome/installer/util/installer_state_unittest.cc
+++ b/chrome/installer/util/installer_state_unittest.cc
@@ -276,9 +276,9 @@ TEST_F(InstallerStateTest, Basic) {
EXPECT_FALSE(installer_dir.empty());
base::FilePath new_version_dir(installer_state.target_path().Append(
- UTF8ToWide(new_version.GetString())));
+ base::UTF8ToWide(new_version.GetString())));
base::FilePath old_version_dir(installer_state.target_path().Append(
- UTF8ToWide(old_version.GetString())));
+ base::UTF8ToWide(old_version.GetString())));
EXPECT_FALSE(file_util::PathExists(new_version_dir));
EXPECT_FALSE(file_util::PathExists(old_version_dir));
@@ -361,7 +361,8 @@ TEST_F(InstallerStateTest, WithProduct) {
EXPECT_TRUE(chrome_key.Valid());
if (chrome_key.Valid()) {
chrome_key.WriteValue(google_update::kRegVersionField,
- UTF8ToWide(current_version.GetString()).c_str());
+ base::UTF8ToWide(
+ current_version.GetString()).c_str());
machine_state.Initialize();
// TODO(tommi): Also test for when there exists a new_chrome.exe.
Version found_version(*installer_state.GetCurrentVersion(machine_state));
@@ -532,11 +533,12 @@ TEST_F(InstallerStateTest, MAYBE_RemoveOldVersionDirs) {
installer_state.target_path().Append(L"1.2.3.4"),
installer_state.target_path().Append(L"1.2.3.5"),
installer_state.target_path().Append(L"1.2.3.6"),
- installer_state.target_path().Append(ASCIIToWide(kOldVersion)),
- installer_state.target_path().Append(ASCIIToWide(kOldChromeExeVersion)),
+ installer_state.target_path().Append(base::ASCIIToWide(kOldVersion)),
+ installer_state.target_path().Append(
+ base::ASCIIToWide(kOldChromeExeVersion)),
installer_state.target_path().Append(L"2.1.1.0"),
- installer_state.target_path().Append(ASCIIToWide(kChromeExeVersion)),
- installer_state.target_path().Append(ASCIIToWide(kNewVersion)),
+ installer_state.target_path().Append(base::ASCIIToWide(kChromeExeVersion)),
+ installer_state.target_path().Append(base::ASCIIToWide(kNewVersion)),
installer_state.target_path().Append(L"3.9.1.1"),
};
@@ -597,7 +599,7 @@ TEST_F(InstallerStateTest, MAYBE_RemoveOldVersionDirs) {
for (base::FilePath next_version = version_enum.Next(); !next_version.empty();
next_version = version_enum.Next()) {
base::FilePath dir_name(next_version.BaseName());
- Version version(WideToASCII(dir_name.value()));
+ Version version(base::WideToASCII(dir_name.value()));
if (version.IsValid()) {
EXPECT_TRUE(expected_remaining_dirs.erase(version.GetString()))
<< "Unexpected version dir found: " << version.GetString();
@@ -643,7 +645,7 @@ class InstallerStateCriticalVersionTest : public ::testing::Test {
CommandLine::FromString(L"setup.exe") :
CommandLine::FromString(
L"setup.exe --critical-update-version=" +
- ASCIIToWide(version->GetString()));
+ base::ASCIIToWide(version->GetString()));
prefs_.reset(new MasterPreferences(cmd_line_));
machine_state_.Initialize();
installer_state_.Initialize(cmd_line_, *prefs_, machine_state_);
« no previous file with comments | « chrome/installer/util/installer_state.cc ('k') | chrome/installer/util/logging_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698