Issue 12314024: Merge 183575

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12314024: Merge 183575 (Closed)

Created:
7 years, 10 months ago by Roger Tawa OOO till Jul 10th

Modified:
7 years, 10 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

Merge 183575 > When signing in to chrome explicitly (first run, ntp, wrench) don't wait for > signin manager and/or sync to finish before navigating away from the blank > page. The user will see the NTP much sooner, with the welcome bubble. In > the case of a subsequent error, the NTP is reloaded to show the error message > in the bubble. > > BUG=176190 > > > Review URL: https://chromiumcodereview.appspot.com/12289003 TBR=rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183690

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/sync/one_click_signin_helper.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed manually as r183690.