Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: test/builddir/gyptest-all.py

Issue 12314014: CMake generator. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Cleaner status munging. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/builddir/gyptest-all.py
===================================================================
--- test/builddir/gyptest-all.py (revision 1787)
+++ test/builddir/gyptest-all.py (working copy)
@@ -23,9 +23,8 @@
# its sources. I'm not sure if make is wrong for writing outside the current
# directory, or if the test is wrong for assuming everything generated is under
# the current directory.
-# Android does not support setting the build directory.
-# Ninja does not support relocation.
-test = TestGyp.TestGyp(formats=['!make', '!ninja', '!android'])
+# Android, Ninja, and CMake do not support setting the build directory.
Nico 2013/11/19 16:35:28 Ninja has -Goutput_dir, but not sure what "build d
bungeman-chromium 2013/11/20 20:54:51 Heh, I had the same issue with 'relocation'. From
+test = TestGyp.TestGyp(formats=['!make', '!ninja', '!android', '!cmake'])
test.run_gyp('prog1.gyp', '--depth=..', chdir='src')
if test.format == 'msvs':

Powered by Google App Engine
This is Rietveld 408576698