Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 12314013: [Android] Use 1/4 scale low resolution tiles on high-res devices (Closed)

Created:
7 years, 10 months ago by Sami
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

[Android] Use 1/4 scale low resolution tiles on high-res devices If a device has a screen with a high enough resolution for us to start using 512x512 tiles, use 1/4 scale low resolution tiles instead of 1/8 ones. This makes page content -- especially text -- look less fuzzy while scrolling. BUG=175976

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -17 lines) Patch
M cc/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_info_collector_android.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +41 lines, -17 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
Sami
This version enables 1/4 res tiles on devices where we use 512x512 tiles.
7 years, 10 months ago (2013-02-20 15:29:08 UTC) #1
Tom Hudson
LGTM
7 years, 10 months ago (2013-02-20 15:56:49 UTC) #2
klobag.chromium
https://codereview.chromium.org/12314013/diff/1/content/renderer/gpu/render_widget_compositor.cc File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/12314013/diff/1/content/renderer/gpu/render_widget_compositor.cc#newcode134 content/renderer/gpu/render_widget_compositor.cc:134: const int kMinSlowDownScaleFactor = 0; Shouldn't min be 1? ...
7 years, 10 months ago (2013-02-20 16:38:22 UTC) #3
Sami
https://codereview.chromium.org/12314013/diff/1/content/renderer/gpu/render_widget_compositor.cc File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/12314013/diff/1/content/renderer/gpu/render_widget_compositor.cc#newcode134 content/renderer/gpu/render_widget_compositor.cc:134: const int kMinSlowDownScaleFactor = 0; On 2013/02/20 16:38:22, klobag.chromium ...
7 years, 10 months ago (2013-02-20 16:45:14 UTC) #4
nduca
your'e mixing and matching terms here. 4 isn't a factor, 0.25 is a factor. Pass ...
7 years, 10 months ago (2013-02-20 17:55:44 UTC) #5
nduca
Should we close this?
7 years, 9 months ago (2013-03-13 06:03:07 UTC) #6
Sami (do not use)
7 years, 9 months ago (2013-03-13 10:28:48 UTC) #7
Yup, done.


On 13 March 2013 06:03, <nduca@chromium.org> wrote:

> Should we close this?
>
>
https://codereview.chromium.**org/12314013/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698