Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12314012: Ensure deopt entries have no relocation information. (Closed)

Created:
7 years, 10 months ago by Michael Starzinger
Modified:
7 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Ensure deopt entries have no relocation information. R=ulan@chromium.org BUG=chromium:176943 Committed: http://code.google.com/p/v8/source/detail?r=13698

Patch Set 1 #

Patch Set 2 : Factor out check into separate method. #

Patch Set 3 : Ported to MIPS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M src/arm/codegen-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 10 months ago (2013-02-20 12:36:09 UTC) #1
ulan
LGTM
7 years, 10 months ago (2013-02-20 13:11:03 UTC) #2
Michael Starzinger
7 years, 10 months ago (2013-02-20 13:12:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r13698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698