Issue 1231383005: Revert of Bilinear optimization for 1D convolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1231383005: Revert of Bilinear optimization for 1D convolution. (Closed)

Created:
5 years, 5 months ago by scroggo

Modified:
5 years, 5 months ago

Reviewers:
bsalomon, Stephen White, ericrk

CC:
reviews_skia.org, vmiuraomon_google.com, Stephen White

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Bilinear optimization for 1D convolution. (patchset #5 id:200001 of https://codereview.chromium.org/1216623003/) Reason for revert: Breaks MSAA Original issue's description: > Bilinear optimization for 1D convolution. > > Splits GrGLConvolutionEffect into GrGLBilerpConvolutionEffect and > GrGLBoundedConvolutionEffect. When doing a non-bounded convolution we now > always use the GrGLBilerpConvolutionEffect which uses bilinear filtering to > perform half as many samples in the texture. > > BUG=skia:3986 > > Committed: https://skia.googlesource.com/skia/+/91abe10af417148939548551e210c001022d3bda TBR=bsalomon@google.com,senorblanco@chromium.org,ericrk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3986 Committed: https://skia.googlesource.com/skia/+/39a24f29940efb69a2ecc0438397c88cd1b681c0

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -305 lines)			Patch
	M	src/gpu/effects/Gr1DKernelEffect.h	View		1 chunk	+0 lines, -14 lines	0 comments	Download
	M	src/gpu/effects/GrConvolutionEffect.cpp	View		6 chunks	+114 lines, -291 lines	0 comments	Download

Total messages: 3 (0 generated)

scroggo

Created Revert of Bilinear optimization for 1D convolution.

5 years, 5 months ago (2015-07-13 14:06:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231383005/1

5 years, 5 months ago (2015-07-13 14:06:35 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-13 14:06:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/39a24f29940efb69a2ecc0438397c88cd1b681c0