Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: Source/core/layout/LayoutText.h

Issue 1231363003: Fix virtual/override/final usage in Source/core/layout/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutTestHelper.cpp ('k') | Source/core/layout/LayoutText.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutText.h
diff --git a/Source/core/layout/LayoutText.h b/Source/core/layout/LayoutText.h
index 6e66fbb7c34d5e891056005d93761413cc2fd056..dd29139cf542c7bec2d9c84573e862ead9c70e9c 100644
--- a/Source/core/layout/LayoutText.h
+++ b/Source/core/layout/LayoutText.h
@@ -44,10 +44,10 @@ public:
// doesn't re-transform the string.
LayoutText(Node*, PassRefPtr<StringImpl>);
#if ENABLE(ASSERT)
- virtual ~LayoutText();
+ ~LayoutText() override;
#endif
- virtual const char* name() const override { return "LayoutText"; }
+ const char* name() const override { return "LayoutText"; }
virtual bool isTextFragment() const;
virtual bool isWordBreak() const;
@@ -66,16 +66,16 @@ public:
void dirtyOrDeleteLineBoxesIfNeeded(bool fullLayout);
void dirtyLineBoxes();
- virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const override final;
+ void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const final;
void absoluteRectsForRange(Vector<IntRect>&, unsigned startOffset = 0, unsigned endOffset = INT_MAX, bool useSelectionHeight = false, bool* wasFixed = nullptr);
- virtual void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override final;
+ void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const final;
void absoluteQuadsForRange(Vector<FloatQuad>&, unsigned startOffset = 0, unsigned endOffset = INT_MAX, bool useSelectionHeight = false, bool* wasFixed = nullptr);
enum ClippingOption { NoClipping, ClipToEllipsis };
void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed = nullptr, ClippingOption = NoClipping) const;
- virtual PositionWithAffinity positionForPoint(const LayoutPoint&) override;
+ PositionWithAffinity positionForPoint(const LayoutPoint&) override;
bool is8Bit() const { return m_text.is8Bit(); }
const LChar* characters8() const { return m_text.impl()->characters8(); }
@@ -113,21 +113,21 @@ public:
virtual void transformText();
- virtual bool canBeSelectionLeaf() const override { return true; }
- virtual void setSelectionState(SelectionState) override final;
- virtual LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer) const override;
- virtual LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* extraWidthToEndOfLine = nullptr) override;
+ bool canBeSelectionLeaf() const override { return true; }
+ void setSelectionState(SelectionState) final;
+ LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer) const override;
+ LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* extraWidthToEndOfLine = nullptr) override;
InlineTextBox* firstTextBox() const { return m_firstTextBox; }
InlineTextBox* lastTextBox() const { return m_lastTextBox; }
- virtual int caretMinOffset() const override;
- virtual int caretMaxOffset() const override;
+ int caretMinOffset() const override;
+ int caretMaxOffset() const override;
unsigned resolvedTextLength() const;
- virtual int previousOffset(int current) const override final;
- virtual int previousOffsetForBackwardDeletion(int current) const override final;
- virtual int nextOffset(int current) const override final;
+ int previousOffset(int current) const final;
+ int previousOffsetForBackwardDeletion(int current) const final;
+ int nextOffset(int current) const final;
bool containsReversedText() const { return m_containsReversedText; }
@@ -145,19 +145,19 @@ public:
float hyphenWidth(const Font&, TextDirection);
protected:
- virtual void willBeDestroyed() override;
+ void willBeDestroyed() override;
- virtual void styleWillChange(StyleDifference, const ComputedStyle&) override final { }
- virtual void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;
+ void styleWillChange(StyleDifference, const ComputedStyle&) final { }
+ void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;
virtual void setTextInternal(PassRefPtr<StringImpl>);
virtual UChar previousCharacter() const;
- virtual void addLayerHitTestRects(LayerHitTestRects&, const DeprecatedPaintLayer* currentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) const override;
+ void addLayerHitTestRects(LayerHitTestRects&, const DeprecatedPaintLayer* currentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) const override;
virtual InlineTextBox* createTextBox(int start, unsigned short length); // Subclassed by SVG.
- virtual void invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidationContainer) const override;
+ void invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidationContainer) const override;
private:
void computePreferredLogicalWidths(float leadWidth);
@@ -168,11 +168,11 @@ private:
// Make length() private so that callers that have a LayoutText*
// will use the more efficient textLength() instead, while
// callers with a LayoutObject* can continue to use length().
- virtual unsigned length() const override final { return textLength(); }
+ unsigned length() const final { return textLength(); }
- virtual void paint(const PaintInfo&, const LayoutPoint&) override final { ASSERT_NOT_REACHED(); }
- virtual void layout() override final { ASSERT_NOT_REACHED(); }
- virtual bool nodeAtPoint(HitTestResult&, const HitTestLocation&, const LayoutPoint&, HitTestAction) override final { ASSERT_NOT_REACHED(); return false; }
+ void paint(const PaintInfo&, const LayoutPoint&) final { ASSERT_NOT_REACHED(); }
+ void layout() final { ASSERT_NOT_REACHED(); }
+ bool nodeAtPoint(HitTestResult&, const HitTestLocation&, const LayoutPoint&, HitTestAction) final { ASSERT_NOT_REACHED(); return false; }
void deleteTextBoxes();
bool containsOnlyWhitespace(unsigned from, unsigned len) const;
@@ -182,7 +182,7 @@ private:
bool isText() const = delete; // This will catch anyone doing an unnecessary check.
- virtual LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* = nullptr) const override;
+ LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* = nullptr) const override;
void checkConsistency() const;
« no previous file with comments | « Source/core/layout/LayoutTestHelper.cpp ('k') | Source/core/layout/LayoutText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698