Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: Source/core/layout/svg/LayoutSVGText.h

Issue 1231363003: Fix virtual/override/final usage in Source/core/layout/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/svg/LayoutSVGTSpan.h ('k') | Source/core/layout/svg/LayoutSVGTextPath.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 17 matching lines...) Expand all
28 28
29 namespace blink { 29 namespace blink {
30 30
31 class LayoutSVGInlineText; 31 class LayoutSVGInlineText;
32 class SVGTextElement; 32 class SVGTextElement;
33 class LayoutSVGInlineText; 33 class LayoutSVGInlineText;
34 34
35 class LayoutSVGText final : public LayoutSVGBlock { 35 class LayoutSVGText final : public LayoutSVGBlock {
36 public: 36 public:
37 explicit LayoutSVGText(SVGTextElement*); 37 explicit LayoutSVGText(SVGTextElement*);
38 virtual ~LayoutSVGText(); 38 ~LayoutSVGText() override;
39 39
40 virtual bool isChildAllowed(LayoutObject*, const ComputedStyle&) const overr ide; 40 bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override;
41 41
42 void setNeedsPositioningValuesUpdate() { m_needsPositioningValuesUpdate = tr ue; } 42 void setNeedsPositioningValuesUpdate() { m_needsPositioningValuesUpdate = tr ue; }
43 virtual void setNeedsTransformUpdate() override { m_needsTransformUpdate = t rue; } 43 void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; }
44 void setNeedsTextMetricsUpdate() { m_needsTextMetricsUpdate = true; } 44 void setNeedsTextMetricsUpdate() { m_needsTextMetricsUpdate = true; }
45 virtual FloatRect paintInvalidationRectInLocalCoordinates() const override; 45 FloatRect paintInvalidationRectInLocalCoordinates() const override;
46 46
47 static LayoutSVGText* locateLayoutSVGTextAncestor(LayoutObject*); 47 static LayoutSVGText* locateLayoutSVGTextAncestor(LayoutObject*);
48 static const LayoutSVGText* locateLayoutSVGTextAncestor(const LayoutObject*) ; 48 static const LayoutSVGText* locateLayoutSVGTextAncestor(const LayoutObject*) ;
49 49
50 bool needsReordering() const { return m_needsReordering; } 50 bool needsReordering() const { return m_needsReordering; }
51 Vector<SVGTextLayoutAttributes*>& layoutAttributes() { return m_layoutAttrib utes; } 51 Vector<SVGTextLayoutAttributes*>& layoutAttributes() { return m_layoutAttrib utes; }
52 52
53 void subtreeChildWasAdded(LayoutObject*); 53 void subtreeChildWasAdded(LayoutObject*);
54 void subtreeChildWillBeRemoved(LayoutObject*, Vector<SVGTextLayoutAttributes *, 2>& affectedAttributes); 54 void subtreeChildWillBeRemoved(LayoutObject*, Vector<SVGTextLayoutAttributes *, 2>& affectedAttributes);
55 void subtreeChildWasRemoved(const Vector<SVGTextLayoutAttributes*, 2>& affec tedAttributes); 55 void subtreeChildWasRemoved(const Vector<SVGTextLayoutAttributes*, 2>& affec tedAttributes);
56 void subtreeStyleDidChange(); 56 void subtreeStyleDidChange();
57 void subtreeTextDidChange(LayoutSVGInlineText*); 57 void subtreeTextDidChange(LayoutSVGInlineText*);
58 58
59 virtual const AffineTransform& localToParentTransform() const override { ret urn m_localTransform; } 59 const AffineTransform& localToParentTransform() const override { return m_lo calTransform; }
60 60
61 virtual const char* name() const override { return "LayoutSVGText"; } 61 const char* name() const override { return "LayoutSVGText"; }
62 62
63 private: 63 private:
64 virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectSVGText || LayoutSVGBlock::isOfType(type); } 64 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVGText || LayoutSVGBlock::isOfType(type); }
65 65
66 virtual void paint(const PaintInfo&, const LayoutPoint&) override; 66 void paint(const PaintInfo&, const LayoutPoint&) override;
67 virtual bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParen t, HitTestAction) override; 67 bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTe stAction) override;
68 virtual PositionWithAffinity positionForPoint(const LayoutPoint&) override; 68 PositionWithAffinity positionForPoint(const LayoutPoint&) override;
69 69
70 virtual void layout() override; 70 void layout() override;
71 71
72 virtual void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const overrid e; 72 void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override;
73 73
74 virtual void addChild(LayoutObject* child, LayoutObject* beforeChild = nullp tr) override; 74 void addChild(LayoutObject* child, LayoutObject* beforeChild = nullptr) over ride;
75 virtual void removeChild(LayoutObject*) override; 75 void removeChild(LayoutObject*) override;
76 virtual void willBeDestroyed() override; 76 void willBeDestroyed() override;
77 77
78 virtual FloatRect objectBoundingBox() const override { return frameRect(); } 78 FloatRect objectBoundingBox() const override { return frameRect(); }
79 virtual FloatRect strokeBoundingBox() const override; 79 FloatRect strokeBoundingBox() const override;
80 80
81 virtual RootInlineBox* createRootInlineBox() override; 81 RootInlineBox* createRootInlineBox() override;
82 82
83 bool shouldHandleSubtreeMutations() const; 83 bool shouldHandleSubtreeMutations() const;
84 84
85 bool m_needsReordering : 1; 85 bool m_needsReordering : 1;
86 bool m_needsPositioningValuesUpdate : 1; 86 bool m_needsPositioningValuesUpdate : 1;
87 bool m_needsTransformUpdate : 1; 87 bool m_needsTransformUpdate : 1;
88 bool m_needsTextMetricsUpdate : 1; 88 bool m_needsTextMetricsUpdate : 1;
89 SVGTextLayoutAttributesBuilder m_layoutAttributesBuilder; 89 SVGTextLayoutAttributesBuilder m_layoutAttributesBuilder;
90 Vector<SVGTextLayoutAttributes*> m_layoutAttributes; 90 Vector<SVGTextLayoutAttributes*> m_layoutAttributes;
91 }; 91 };
92 92
93 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGText, isSVGText()); 93 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGText, isSVGText());
94 94
95 } 95 }
96 96
97 #endif 97 #endif
OLDNEW
« no previous file with comments | « Source/core/layout/svg/LayoutSVGTSpan.h ('k') | Source/core/layout/svg/LayoutSVGTextPath.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698