Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: Source/core/layout/LayoutTableRow.h

Issue 1231363003: Fix virtual/override/final usage in Source/core/layout/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutTableCol.h ('k') | Source/core/layout/LayoutTableSection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserv ed. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserv ed.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 LayoutTableRow* nextRow() const; 44 LayoutTableRow* nextRow() const;
45 45
46 const LayoutObjectChildList* children() const { return &m_children; } 46 const LayoutObjectChildList* children() const { return &m_children; }
47 LayoutObjectChildList* children() { return &m_children; } 47 LayoutObjectChildList* children() { return &m_children; }
48 48
49 LayoutTableSection* section() const { return toLayoutTableSection(parent()); } 49 LayoutTableSection* section() const { return toLayoutTableSection(parent()); }
50 LayoutTable* table() const { return toLayoutTable(parent()->parent()); } 50 LayoutTable* table() const { return toLayoutTable(parent()->parent()); }
51 51
52 static LayoutTableRow* createAnonymous(Document*); 52 static LayoutTableRow* createAnonymous(Document*);
53 static LayoutTableRow* createAnonymousWithParent(const LayoutObject*); 53 static LayoutTableRow* createAnonymousWithParent(const LayoutObject*);
54 virtual LayoutBox* createAnonymousBoxWithSameTypeAs(const LayoutObject* pare nt) const override 54 LayoutBox* createAnonymousBoxWithSameTypeAs(const LayoutObject* parent) cons t override
55 { 55 {
56 return createAnonymousWithParent(parent); 56 return createAnonymousWithParent(parent);
57 } 57 }
58 58
59 void setRowIndex(unsigned rowIndex) 59 void setRowIndex(unsigned rowIndex)
60 { 60 {
61 if (UNLIKELY(rowIndex > maxRowIndex)) 61 if (UNLIKELY(rowIndex > maxRowIndex))
62 CRASH(); 62 CRASH();
63 63
64 m_rowIndex = rowIndex; 64 m_rowIndex = rowIndex;
(...skipping 19 matching lines...) Expand all
84 { 84 {
85 if (section()->hasSameDirectionAs(table())) 85 if (section()->hasSameDirectionAs(table()))
86 return style()->borderEnd(); 86 return style()->borderEnd();
87 87
88 return style()->borderStart(); 88 return style()->borderStart();
89 } 89 }
90 90
91 const BorderValue& borderAdjoiningStartCell(const LayoutTableCell*) const; 91 const BorderValue& borderAdjoiningStartCell(const LayoutTableCell*) const;
92 const BorderValue& borderAdjoiningEndCell(const LayoutTableCell*) const; 92 const BorderValue& borderAdjoiningEndCell(const LayoutTableCell*) const;
93 93
94 virtual bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInCo ntainer, const LayoutPoint& accumulatedOffset, HitTestAction) override; 94 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
95 95
96 void addOverflowFromCell(const LayoutTableCell*); 96 void addOverflowFromCell(const LayoutTableCell*);
97 97
98 virtual const char* name() const override { return "LayoutTableRow"; } 98 const char* name() const override { return "LayoutTableRow"; }
99 99
100 private: 100 private:
101 virtual LayoutObjectChildList* virtualChildren() override { return children( ); } 101 LayoutObjectChildList* virtualChildren() override { return children(); }
102 virtual const LayoutObjectChildList* virtualChildren() const override { retu rn children(); } 102 const LayoutObjectChildList* virtualChildren() const override { return child ren(); }
103 103
104 virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectTableRow || LayoutBox::isOfType(type); } 104 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectTableRow || LayoutBox::isOfType(type); }
105 105
106 virtual void willBeRemovedFromTree() override; 106 void willBeRemovedFromTree() override;
107 107
108 virtual void addChild(LayoutObject* child, LayoutObject* beforeChild = nullp tr) override; 108 void addChild(LayoutObject* child, LayoutObject* beforeChild = nullptr) over ride;
109 virtual void layout() override; 109 void layout() override;
110 110
111 virtual DeprecatedPaintLayerType layerTypeRequired() const override 111 DeprecatedPaintLayerType layerTypeRequired() const override
112 { 112 {
113 if (hasTransformRelatedProperty() || hasHiddenBackface() || hasClipPath( ) || createsGroup() || style()->shouldCompositeForCurrentAnimations() || style() ->hasCompositorProxy()) 113 if (hasTransformRelatedProperty() || hasHiddenBackface() || hasClipPath( ) || createsGroup() || style()->shouldCompositeForCurrentAnimations() || style() ->hasCompositorProxy())
114 return NormalDeprecatedPaintLayer; 114 return NormalDeprecatedPaintLayer;
115 115
116 if (hasOverflowClip()) 116 if (hasOverflowClip())
117 return OverflowClipDeprecatedPaintLayer; 117 return OverflowClipDeprecatedPaintLayer;
118 118
119 return NoDeprecatedPaintLayer; 119 return NoDeprecatedPaintLayer;
120 } 120 }
121 121
122 virtual void paint(const PaintInfo&, const LayoutPoint&) override; 122 void paint(const PaintInfo&, const LayoutPoint&) override;
123 123
124 virtual void imageChanged(WrappedImagePtr, const IntRect* = nullptr) overrid e; 124 void imageChanged(WrappedImagePtr, const IntRect* = nullptr) override;
125 125
126 virtual void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override; 126 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ;
127 127
128 void nextSibling() const = delete; 128 void nextSibling() const = delete;
129 void previousSibling() const = delete; 129 void previousSibling() const = delete;
130 130
131 LayoutObjectChildList m_children; 131 LayoutObjectChildList m_children;
132 unsigned m_rowIndex : 31; 132 unsigned m_rowIndex : 31;
133 }; 133 };
134 134
135 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableRow, isTableRow()); 135 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableRow, isTableRow());
136 136
(...skipping 15 matching lines...) Expand all
152 152
153 inline LayoutTableRow* LayoutTableSection::lastRow() const 153 inline LayoutTableRow* LayoutTableSection::lastRow() const
154 { 154 {
155 ASSERT(children() == virtualChildren()); 155 ASSERT(children() == virtualChildren());
156 return toLayoutTableRow(children()->lastChild()); 156 return toLayoutTableRow(children()->lastChild());
157 } 157 }
158 158
159 } // namespace blink 159 } // namespace blink
160 160
161 #endif // LayoutTableRow_h 161 #endif // LayoutTableRow_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTableCol.h ('k') | Source/core/layout/LayoutTableSection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698