Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/core/layout/LayoutScrollbar.h

Issue 1231363003: Fix virtual/override/final usage in Source/core/layout/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutRubyText.h ('k') | Source/core/layout/LayoutScrollbarPart.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 24 matching lines...) Expand all
35 35
36 class LocalFrame; 36 class LocalFrame;
37 class Node; 37 class Node;
38 class LayoutBox; 38 class LayoutBox;
39 class LayoutScrollbarPart; 39 class LayoutScrollbarPart;
40 class ComputedStyle; 40 class ComputedStyle;
41 41
42 class LayoutScrollbar final : public Scrollbar { 42 class LayoutScrollbar final : public Scrollbar {
43 public: 43 public:
44 static PassRefPtrWillBeRawPtr<Scrollbar> createCustomScrollbar(ScrollableAre a*, ScrollbarOrientation, Node*, LocalFrame* owningFrame = nullptr); 44 static PassRefPtrWillBeRawPtr<Scrollbar> createCustomScrollbar(ScrollableAre a*, ScrollbarOrientation, Node*, LocalFrame* owningFrame = nullptr);
45 virtual ~LayoutScrollbar(); 45 ~LayoutScrollbar() override;
46 46
47 LayoutBox* owningLayoutObject() const; 47 LayoutBox* owningLayoutObject() const;
48 48
49 IntRect buttonRect(ScrollbarPart); 49 IntRect buttonRect(ScrollbarPart);
50 IntRect trackRect(int startLength, int endLength); 50 IntRect trackRect(int startLength, int endLength);
51 IntRect trackPieceRectWithMargins(ScrollbarPart, const IntRect&); 51 IntRect trackPieceRectWithMargins(ScrollbarPart, const IntRect&);
52 52
53 int minimumThumbLength(); 53 int minimumThumbLength();
54 54
55 virtual bool isOverlayScrollbar() const override { return false; } 55 bool isOverlayScrollbar() const override { return false; }
56 56
57 LayoutScrollbarPart* getPart(ScrollbarPart partType) { return m_parts.get(pa rtType); } 57 LayoutScrollbarPart* getPart(ScrollbarPart partType) { return m_parts.get(pa rtType); }
58 58
59 virtual void invalidateRect(const IntRect&) override; 59 void invalidateRect(const IntRect&) override;
60 60
61 DECLARE_VIRTUAL_TRACE(); 61 DECLARE_VIRTUAL_TRACE();
62 62
63 protected: 63 protected:
64 LayoutScrollbar(ScrollableArea*, ScrollbarOrientation, Node*, LocalFrame*); 64 LayoutScrollbar(ScrollableArea*, ScrollbarOrientation, Node*, LocalFrame*);
65 65
66 private: 66 private:
67 friend class Scrollbar; 67 friend class Scrollbar;
68 68
69 virtual void setParent(Widget*) override; 69 void setParent(Widget*) override;
70 virtual void setEnabled(bool) override; 70 void setEnabled(bool) override;
71 71
72 virtual void setHoveredPart(ScrollbarPart) override; 72 void setHoveredPart(ScrollbarPart) override;
73 virtual void setPressedPart(ScrollbarPart) override; 73 void setPressedPart(ScrollbarPart) override;
74 74
75 virtual void styleChanged() override; 75 void styleChanged() override;
76 76
77 virtual bool isCustomScrollbar() const override { return true; } 77 bool isCustomScrollbar() const override { return true; }
78 78
79 void updateScrollbarParts(bool destroy = false); 79 void updateScrollbarParts(bool destroy = false);
80 80
81 PassRefPtr<ComputedStyle> getScrollbarPseudoStyle(ScrollbarPart, PseudoId); 81 PassRefPtr<ComputedStyle> getScrollbarPseudoStyle(ScrollbarPart, PseudoId);
82 void updateScrollbarPart(ScrollbarPart, bool destroy = false); 82 void updateScrollbarPart(ScrollbarPart, bool destroy = false);
83 83
84 // This Scrollbar(Widget) may outlive the DOM which created it (during tear down), 84 // This Scrollbar(Widget) may outlive the DOM which created it (during tear down),
85 // so we keep a reference to the Node which caused this custom scrollbar cre ation. 85 // so we keep a reference to the Node which caused this custom scrollbar cre ation.
86 // This will not create a reference cycle as the Widget tree is owned by our containing 86 // This will not create a reference cycle as the Widget tree is owned by our containing
87 // FrameView which this Node pointer can in no way keep alive. See webkit bu g 80610. 87 // FrameView which this Node pointer can in no way keep alive. See webkit bu g 80610.
88 RefPtrWillBeMember<Node> m_owner; 88 RefPtrWillBeMember<Node> m_owner;
89 89
90 RawPtrWillBeMember<LocalFrame> m_owningFrame; 90 RawPtrWillBeMember<LocalFrame> m_owningFrame;
91 91
92 HashMap<unsigned, LayoutScrollbarPart*> m_parts; 92 HashMap<unsigned, LayoutScrollbarPart*> m_parts;
93 }; 93 };
94 94
95 DEFINE_TYPE_CASTS(LayoutScrollbar, ScrollbarThemeClient, scrollbar, scrollbar->i sCustomScrollbar(), scrollbar.isCustomScrollbar()); 95 DEFINE_TYPE_CASTS(LayoutScrollbar, ScrollbarThemeClient, scrollbar, scrollbar->i sCustomScrollbar(), scrollbar.isCustomScrollbar());
96 96
97 } // namespace blink 97 } // namespace blink
98 98
99 #endif // LayoutScrollbar_h 99 #endif // LayoutScrollbar_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutRubyText.h ('k') | Source/core/layout/LayoutScrollbarPart.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698