Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: Source/core/layout/LayoutRubyRun.h

Issue 1231363003: Fix virtual/override/final usage in Source/core/layout/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutRubyBase.h ('k') | Source/core/layout/LayoutRubyText.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 namespace blink { 36 namespace blink {
37 37
38 class LayoutRubyBase; 38 class LayoutRubyBase;
39 class LayoutRubyText; 39 class LayoutRubyText;
40 40
41 // LayoutRubyRun are 'inline-block/table' like objects,and wrap a single pairing of a ruby base with its ruby text(s). 41 // LayoutRubyRun are 'inline-block/table' like objects,and wrap a single pairing of a ruby base with its ruby text(s).
42 // See LayoutRuby.h for further comments on the structure 42 // See LayoutRuby.h for further comments on the structure
43 43
44 class LayoutRubyRun final : public LayoutBlockFlow { 44 class LayoutRubyRun final : public LayoutBlockFlow {
45 public: 45 public:
46 virtual ~LayoutRubyRun(); 46 ~LayoutRubyRun() override;
47 47
48 bool hasRubyText() const; 48 bool hasRubyText() const;
49 bool hasRubyBase() const; 49 bool hasRubyBase() const;
50 LayoutRubyText* rubyText() const; 50 LayoutRubyText* rubyText() const;
51 LayoutRubyBase* rubyBase() const; 51 LayoutRubyBase* rubyBase() const;
52 LayoutRubyBase* rubyBaseSafe(); // creates the base if it doesn't already ex ist 52 LayoutRubyBase* rubyBaseSafe(); // creates the base if it doesn't already ex ist
53 53
54 virtual LayoutObject* layoutSpecialExcludedChild(bool relayoutChildren, Subt reeLayoutScope&) override; 54 LayoutObject* layoutSpecialExcludedChild(bool relayoutChildren, SubtreeLayou tScope&) override;
55 virtual void layout() override; 55 void layout() override;
56 56
57 virtual bool isChildAllowed(LayoutObject*, const ComputedStyle&) const overr ide; 57 bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override;
58 virtual void addChild(LayoutObject* child, LayoutObject* beforeChild = nullp tr) override; 58 void addChild(LayoutObject* child, LayoutObject* beforeChild = nullptr) over ride;
59 virtual void removeChild(LayoutObject* child) override; 59 void removeChild(LayoutObject* child) override;
60 60
61 void getOverhang(bool firstLine, LayoutObject* startLayoutObject, LayoutObje ct* endLayoutObject, int& startOverhang, int& endOverhang) const; 61 void getOverhang(bool firstLine, LayoutObject* startLayoutObject, LayoutObje ct* endLayoutObject, int& startOverhang, int& endOverhang) const;
62 62
63 static LayoutRubyRun* staticCreateRubyRun(const LayoutObject* parentRuby); 63 static LayoutRubyRun* staticCreateRubyRun(const LayoutObject* parentRuby);
64 64
65 virtual const char* name() const override { return "LayoutRubyRun"; } 65 const char* name() const override { return "LayoutRubyRun"; }
66 66
67 protected: 67 protected:
68 LayoutRubyBase* createRubyBase() const; 68 LayoutRubyBase* createRubyBase() const;
69 69
70 private: 70 private:
71 LayoutRubyRun(); 71 LayoutRubyRun();
72 72
73 virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectRubyRun || LayoutBlockFlow::isOfType(type); } 73 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectRubyRun || LayoutBlockFlow::isOfType(type); }
74 virtual bool createsAnonymousWrapper() const override { return true; } 74 bool createsAnonymousWrapper() const override { return true; }
75 virtual void removeLeftoverAnonymousBlock(LayoutBlock*) override { } 75 void removeLeftoverAnonymousBlock(LayoutBlock*) override { }
76 }; 76 };
77 77
78 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutRubyRun, isRubyRun()); 78 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutRubyRun, isRubyRun());
79 79
80 } // namespace blink 80 } // namespace blink
81 81
82 #endif // LayoutRubyRun_h 82 #endif // LayoutRubyRun_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutRubyBase.h ('k') | Source/core/layout/LayoutRubyText.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698