Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: Source/core/layout/LayoutButton.h

Issue 1231363003: Fix virtual/override/final usage in Source/core/layout/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.h ('k') | Source/core/layout/LayoutCounter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005 Apple Computer 2 * Copyright (C) 2005 Apple Computer
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 14 matching lines...) Expand all
25 #include "core/layout/LayoutFlexibleBox.h" 25 #include "core/layout/LayoutFlexibleBox.h"
26 26
27 namespace blink { 27 namespace blink {
28 28
29 // LayoutButtons are just like normal flexboxes except that they will generate a n anonymous block child. 29 // LayoutButtons are just like normal flexboxes except that they will generate a n anonymous block child.
30 // For inputs, they will also generate an anonymous LayoutText and keep its styl e and content up 30 // For inputs, they will also generate an anonymous LayoutText and keep its styl e and content up
31 // to date as the button changes. 31 // to date as the button changes.
32 class LayoutButton final : public LayoutFlexibleBox { 32 class LayoutButton final : public LayoutFlexibleBox {
33 public: 33 public:
34 explicit LayoutButton(Element*); 34 explicit LayoutButton(Element*);
35 virtual ~LayoutButton(); 35 ~LayoutButton() override;
36 36
37 virtual const char* name() const override { return "LayoutButton"; } 37 const char* name() const override { return "LayoutButton"; }
38 virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectLayoutButton || LayoutFlexibleBox::isOfType(type); } 38 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectLayoutButton || LayoutFlexibleBox::isOfType(type); }
39 39
40 virtual bool canBeSelectionLeaf() const override { return node() && node()-> hasEditableStyle(); } 40 bool canBeSelectionLeaf() const override { return node() && node()->hasEdita bleStyle(); }
41 virtual bool canCollapseAnonymousBlockChild() const override { return true; } 41 bool canCollapseAnonymousBlockChild() const override { return true; }
42 42
43 virtual void addChild(LayoutObject* newChild, LayoutObject *beforeChild = nu llptr) override; 43 void addChild(LayoutObject* newChild, LayoutObject *beforeChild = nullptr) o verride;
44 virtual void removeChild(LayoutObject*) override; 44 void removeChild(LayoutObject*) override;
45 virtual void removeLeftoverAnonymousBlock(LayoutBlock*) override { } 45 void removeLeftoverAnonymousBlock(LayoutBlock*) override { }
46 virtual bool createsAnonymousWrapper() const override { return true; } 46 bool createsAnonymousWrapper() const override { return true; }
47 47
48 virtual bool hasControlClip() const override; 48 bool hasControlClip() const override;
49 virtual LayoutRect controlClipRect(const LayoutPoint&) const override; 49 LayoutRect controlClipRect(const LayoutPoint&) const override;
50 50
51 virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode , LinePositionMode) const override; 51 int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePo sitionMode) const override;
52 52
53 private: 53 private:
54 virtual void updateAnonymousChildStyle(const LayoutObject& child, ComputedSt yle& childStyle) const override; 54 void updateAnonymousChildStyle(const LayoutObject& child, ComputedStyle& chi ldStyle) const override;
55 55
56 virtual bool hasLineIfEmpty() const override { return isHTMLInputElement(nod e()); } 56 bool hasLineIfEmpty() const override { return isHTMLInputElement(node()); }
57 57
58 LayoutBlock* m_inner; 58 LayoutBlock* m_inner;
59 }; 59 };
60 60
61 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutButton, isLayoutButton()); 61 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutButton, isLayoutButton());
62 62
63 } // namespace blink 63 } // namespace blink
64 64
65 #endif // LayoutButton_h 65 #endif // LayoutButton_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.h ('k') | Source/core/layout/LayoutCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698