Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: Source/core/layout/LayoutBR.h

Issue 1231363003: Fix virtual/override/final usage in Source/core/layout/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutApplet.h ('k') | Source/core/layout/LayoutBlock.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 14 matching lines...) Expand all
25 25
26 /* 26 /*
27 * The whole class here is a hack to get <br> working, as long as we don't have support for 27 * The whole class here is a hack to get <br> working, as long as we don't have support for
28 * CSS2 :before and :after pseudo elements 28 * CSS2 :before and :after pseudo elements
29 */ 29 */
30 namespace blink { 30 namespace blink {
31 31
32 class LayoutBR final : public LayoutText { 32 class LayoutBR final : public LayoutText {
33 public: 33 public:
34 explicit LayoutBR(Node*); 34 explicit LayoutBR(Node*);
35 virtual ~LayoutBR(); 35 ~LayoutBR() override;
36 36
37 virtual const char* name() const override { return "LayoutBR"; } 37 const char* name() const override { return "LayoutBR"; }
38 38
39 virtual LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObj ect* /* paintInvalidationContainer */) const override { return LayoutRect(); } 39 LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* /* paintInvalidationContainer */) const override { return LayoutRect(); }
40 40
41 virtual float width(unsigned /* from */, unsigned /* len */, const Font&, La youtUnit /* xpos */, TextDirection, HashSet<const SimpleFontData*>* = nullptr /* fallbackFonts */ , FloatRect* /* glyphBounds */ = nullptr) const override { ret urn 0; } 41 float width(unsigned /* from */, unsigned /* len */, const Font&, LayoutUnit /* xpos */, TextDirection, HashSet<const SimpleFontData*>* = nullptr /* fallbac kFonts */ , FloatRect* /* glyphBounds */ = nullptr) const override { return 0; }
42 virtual float width(unsigned /* from */, unsigned /* len */, LayoutUnit /* x pos */, TextDirection, bool = false /* firstLine */, HashSet<const SimpleFontDat a*>* = nullptr /* fallbackFonts */, FloatRect* /* glyphBounds */ = nullptr) cons t override { return 0; } 42 float width(unsigned /* from */, unsigned /* len */, LayoutUnit /* xpos */, TextDirection, bool = false /* firstLine */, HashSet<const SimpleFontData*>* = n ullptr /* fallbackFonts */, FloatRect* /* glyphBounds */ = nullptr) const overri de { return 0; }
43 43
44 int lineHeight(bool firstLine) const; 44 int lineHeight(bool firstLine) const;
45 45
46 // overrides 46 // overrides
47 virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectBr || LayoutText::isOfType(type); } 47 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectBr || LayoutText::isOfType(type); }
48 48
49 virtual int caretMinOffset() const override; 49 int caretMinOffset() const override;
50 virtual int caretMaxOffset() const override; 50 int caretMaxOffset() const override;
51 51
52 virtual PositionWithAffinity positionForPoint(const LayoutPoint&) override f inal; 52 PositionWithAffinity positionForPoint(const LayoutPoint&) final;
53 53
54 protected: 54 protected:
55 virtual void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override; 55 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ;
56 }; 56 };
57 57
58 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBR, isBR()); 58 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBR, isBR());
59 59
60 } // namespace blink 60 } // namespace blink
61 61
62 #endif // LayoutBR_h 62 #endif // LayoutBR_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutApplet.h ('k') | Source/core/layout/LayoutBlock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698