Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: net/quic/quic_session_test.cc

Issue 1231343004: relnote: Change QuicConnectionVisitorInterface::OnStreamFrames to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Fix_flag_quic_delay_retransmission_alarm_97271704
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session_test.cc
diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc
index 389952bf0b4e06d89ece1505b270920f538cb32c..110750b6fddea1e5e67db0d5908b7b56307e0f46 100644
--- a/net/quic/quic_session_test.cc
+++ b/net/quic/quic_session_test.cc
@@ -576,9 +576,7 @@ TEST_P(QuicSessionTestServer, IncreasedTimeoutAfterCryptoHandshake) {
TEST_P(QuicSessionTestServer, RstStreamBeforeHeadersDecompressed) {
// Send two bytes of payload.
QuicStreamFrame data1(kClientDataStreamId1, false, 0, StringPiece("HT"));
- vector<QuicStreamFrame> frames;
- frames.push_back(data1);
- session_.OnStreamFrames(frames);
+ session_.OnStreamFrame(data1);
EXPECT_EQ(1u, session_.GetNumOpenStreams());
EXPECT_CALL(*connection_, SendRstStream(kClientDataStreamId1, _, _));
@@ -596,9 +594,7 @@ TEST_P(QuicSessionTestServer, MultipleRstStreamsCauseSingleConnectionClose) {
// Create valid stream.
QuicStreamFrame data1(kClientDataStreamId1, false, 0, StringPiece("HT"));
- vector<QuicStreamFrame> frames;
- frames.push_back(data1);
- session_.OnStreamFrames(frames);
+ session_.OnStreamFrame(data1);
EXPECT_EQ(1u, session_.GetNumOpenStreams());
// Process first invalid stream reset, resulting in the connection being
@@ -782,9 +778,7 @@ TEST_P(QuicSessionTestServer, ConnectionFlowControlAccountingFinAndLocalReset) {
const QuicStreamOffset kByteOffset =
kInitialSessionFlowControlWindowForTest / 2;
QuicStreamFrame frame(stream->id(), true, kByteOffset, StringPiece());
- vector<QuicStreamFrame> frames;
- frames.push_back(frame);
- session_.OnStreamFrames(frames);
+ session_.OnStreamFrame(frame);
session_.PostProcessAfterData();
EXPECT_TRUE(connection_->connected());
@@ -824,9 +818,7 @@ TEST_P(QuicSessionTestServer, ConnectionFlowControlAccountingFinAfterRst) {
const QuicStreamOffset kByteOffset = 5678;
string body = "hello";
QuicStreamFrame frame(stream->id(), true, kByteOffset, StringPiece(body));
- vector<QuicStreamFrame> frames;
- frames.push_back(frame);
- session_.OnStreamFrames(frames);
+ session_.OnStreamFrame(frame);
QuicStreamOffset total_stream_bytes_sent_by_peer =
kByteOffset + body.length();
@@ -908,9 +900,7 @@ TEST_P(QuicSessionTestServer, FlowControlWithInvalidFinalOffset) {
EXPECT_CALL(*connection_, SendRstStream(stream->id(), _, _));
stream->Reset(QUIC_STREAM_CANCELLED);
QuicStreamFrame frame(stream->id(), true, kLargeOffset, StringPiece());
- vector<QuicStreamFrame> frames;
- frames.push_back(frame);
- session_.OnStreamFrames(frames);
+ session_.OnStreamFrame(frame);
// Check that RST results in connection close.
QuicRstStreamFrame rst_frame(stream->id(), QUIC_STREAM_CANCELLED,
@@ -934,9 +924,7 @@ TEST_P(QuicSessionTestServer, WindowUpdateUnblocksHeadersStream) {
// Unblock the headers stream by supplying a WINDOW_UPDATE.
QuicWindowUpdateFrame window_update_frame(headers_stream->id(),
2 * kMinimumFlowControlSendWindow);
- vector<QuicWindowUpdateFrame> frames;
- frames.push_back(window_update_frame);
- session_.OnWindowUpdateFrames(frames);
+ session_.OnWindowUpdateFrame(window_update_frame);
EXPECT_FALSE(headers_stream->flow_controller()->IsBlocked());
EXPECT_FALSE(session_.IsConnectionFlowControlBlocked());
EXPECT_FALSE(session_.IsStreamFlowControlBlocked());
@@ -958,9 +946,7 @@ TEST_P(QuicSessionTestServer, TooManyUnfinishedStreamsCauseConnectionClose) {
kClientDataStreamId1 + 2 * kMaxStreams + 1;
for (QuicStreamId i = kFirstStreamId; i < kFinalStreamId; i += 2) {
QuicStreamFrame data1(i, false, 0, StringPiece("HT"));
- vector<QuicStreamFrame> frames;
- frames.push_back(data1);
- session_.OnStreamFrames(frames);
+ session_.OnStreamFrame(data1);
EXPECT_EQ(1u, session_.GetNumOpenStreams());
EXPECT_CALL(*connection_, SendRstStream(i, _, _));
session_.CloseStream(i);
@@ -987,9 +973,7 @@ TEST_P(QuicSessionTestServer, DrainingStreamsDoNotCountAsOpened) {
kClientDataStreamId1 + 2 * kMaxStreams + 1;
for (QuicStreamId i = kFirstStreamId; i < kFinalStreamId; i += 2) {
QuicStreamFrame data1(i, true, 0, StringPiece("HT"));
- vector<QuicStreamFrame> frames;
- frames.push_back(data1);
- session_.OnStreamFrames(frames);
+ session_.OnStreamFrame(data1);
EXPECT_EQ(1u, session_.GetNumOpenStreams());
session_.StreamDraining(i);
EXPECT_EQ(0u, session_.GetNumOpenStreams());
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698