Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: net/quic/quic_connection.cc

Issue 1231343004: relnote: Change QuicConnectionVisitorInterface::OnStreamFrames to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Fix_flag_quic_delay_retransmission_alarm_97271704
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index af418c4f23f297231389c6b42b6f3ad4a946933d..f9cbb61c88879e6156a3141c5c044c532eac9585 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -962,50 +962,48 @@ void QuicConnection::OnPacketComplete() {
last_size_, last_header_, time_of_last_received_packet_);
}
- if (!last_stream_frames_.empty()) {
- visitor_->OnStreamFrames(last_stream_frames_);
+ for (const QuicStreamFrame& frame : last_stream_frames_) {
+ visitor_->OnStreamFrame(frame);
+ stats_.stream_bytes_received += frame.data.size();
if (!connected_) {
return;
}
}
- for (const QuicStreamFrame& stream_frame : last_stream_frames_) {
- stats_.stream_bytes_received += stream_frame.data.size();
- }
// Process window updates, blocked, stream resets, acks, then congestion
// feedback.
- if (!last_window_update_frames_.empty()) {
- visitor_->OnWindowUpdateFrames(last_window_update_frames_);
+ for (const QuicWindowUpdateFrame& frame : last_window_update_frames_) {
+ visitor_->OnWindowUpdateFrame(frame);
if (!connected_) {
return;
}
}
- if (!last_blocked_frames_.empty()) {
- visitor_->OnBlockedFrames(last_blocked_frames_);
+ for (const QuicBlockedFrame& frame : last_blocked_frames_) {
+ visitor_->OnBlockedFrame(frame);
if (!connected_) {
return;
}
}
- for (size_t i = 0; i < last_goaway_frames_.size(); ++i) {
- visitor_->OnGoAway(last_goaway_frames_[i]);
+ for (const QuicGoAwayFrame& frame : last_goaway_frames_) {
+ visitor_->OnGoAway(frame);
if (!connected_) {
return;
}
}
- for (size_t i = 0; i < last_rst_frames_.size(); ++i) {
- visitor_->OnRstStream(last_rst_frames_[i]);
+ for (const QuicRstStreamFrame& frame : last_rst_frames_) {
+ visitor_->OnRstStream(frame);
if (!connected_) {
return;
}
}
- for (size_t i = 0; i < last_ack_frames_.size(); ++i) {
- ProcessAckFrame(last_ack_frames_[i]);
+ for (const QuicAckFrame& frame : last_ack_frames_) {
+ ProcessAckFrame(frame);
if (!connected_) {
return;
}
}
- for (size_t i = 0; i < last_stop_waiting_frames_.size(); ++i) {
- ProcessStopWaitingFrame(last_stop_waiting_frames_[i]);
+ for (const QuicStopWaitingFrame& frame : last_stop_waiting_frames_) {
+ ProcessStopWaitingFrame(frame);
if (!connected_) {
return;
}
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698