Scoping error caused crash in CallICNexus::StateFromFeedback

Scoping error caused crash in CallICNexus::StateFromFeedback

A sloppy mode eval call that establishes strict mode will leak that strictness
into the sloppy surrounding scope on recompile. This changes the structure
of the type feedback vector for the function and crashes follow.

The fix is straightforward.

BUG=491536, 503565
LOG=N

Committed: https://crrev.com/ae11f20e26f3ab0e3c14d579baa98c5b19a8eb86
Cr-Commit-Position: refs/heads/master@{#29671}

[mvstanton, 2015-07-15 07:35:45]

mvstanton@chromium.org changed reviewers:
+ rossberg@chromium.org

[mvstanton, 2015-07-15 07:35:45]

Hi Andreas, here are the changes.
I noticed that in test-parser.cc there are now arrow function tests of the kind
you proposed, like (eval) => { "use strict"; }, so I didn't need to add them.
Thanks,
--Michael

[rossberg, 2015-07-15 08:36:52]

LGTM, thanks for cleaning this up.

(It's a pity that we need to pass around the language mode at all. Judging from
the changes you had to do, the only reason really is our elimination of empty
scopes.)

https://codereview.chromium.org/1231343003/diff/20001/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1231343003/diff/20001/src/parser.cc#newcode4043
src/parser.cc:4043: bool use_strict_const = is_strict(language_mode) ||
Does this perhaps already fix this other inconsistency you found as well?

[mvstanton, 2015-07-15 09:13:14]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2015-07-15 09:13:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1231343003/40001

[commit-bot: I haz the power, 2015-07-15 09:14:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-15 09:15:17]

Patchset 3 (id:??) landed as
https://crrev.com/ae11f20e26f3ab0e3c14d579baa98c5b19a8eb86
Cr-Commit-Position: refs/heads/master@{#29671}