Expose a cachePolicy parameter to loadHistoryItem.

[Not to land until https://codereview.chromium.org/101203006/ does]

Expose a cachePolicy parameter to loadHistoryItem.

In some cases, Chromium goes through the loadHistoryItem codepath to perform a
reload if the page to be reloaded isn't in this WebFrame (e.g., when reloading
a sad tab or during a session restore). Expose a cachePolicy parameter so the
embedder can override the default behavior (one of ReturnCacheDataElseLoad or
ReturnCacheDataDontLoad).

BUG=331386
TEST=WebFrameTest.LoadHistoryItemReload

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164592

[davidben, 2014-01-06 22:28:44]

This is the second of a three-legged change. Sending them all out now to get
early feedback, but they should land in order.

japhet: For the Blink-side loader changes and primary review.
abarth: For amended WebFrame API.

I had to change the spelling of #includes in WebFrame.h because checkdeps is
unhappy with 

1. Fix some build dependencies in Chromium exposed by the #include spelling.
https://codereview.chromium.org/101203006/

2. This CL: Expose a new parameter to WebFrame::loadHistoryItem.

[ Wait for Blink roll. ]

3. Use the new parameter in RenderViewImpl with a test.
https://codereview.chromium.org/101203007/

[davidben, 2014-01-06 22:28:44]

This is the second of a three-legged change. Sending them all out now to get
early feedback, but they should land in order.

japhet: For the Blink-side loader changes and primary review.
abarth: For amended WebFrame API.

I had to change the spelling of #includes in WebFrame.h because checkdeps is
unhappy with 

1. Fix some build dependencies in Chromium exposed by the #include spelling.
https://codereview.chromium.org/101203006/

2. This CL: Expose a new parameter to WebFrame::loadHistoryItem.

[ Wait for Blink roll. ]

3. Use the new parameter in RenderViewImpl with a test.
https://codereview.chromium.org/101203007/

[davidben, 2014-01-06 22:30:08]

On 2014/01/06 22:28:44, David Benjamin wrote:
> This is the second of a three-legged change. Sending them all out now to get
> early feedback, but they should land in order.
> 
> japhet: For the Blink-side loader changes and primary review.
> abarth: For amended WebFrame API.
> 
> I had to change the spelling of #includes in WebFrame.h because checkdeps is
> unhappy with 
> 
> 1. Fix some build dependencies in Chromium exposed by the #include spelling.
> https://codereview.chromium.org/101203006/
> 
> 2. This CL: Expose a new parameter to WebFrame::loadHistoryItem.
> 
> [ Wait for Blink roll. ]
> 
> 3. Use the new parameter in RenderViewImpl with a test.
> https://codereview.chromium.org/101203007/

Oof. Apologies for the spam. Apparently I hit Tab and bounced on Enter or
something.

> I had to change the spelling of #includes in WebFrame.h because checkdeps is
> unhappy with 

is unhappy with "../platform/Foo.h". It seems another CL made a similar change,
so I'm guessing "public/platform/Foo.h" is the new spelling?

[Nate Chapin, 2014-01-06 22:33:02]

Source/ changes LGTM

[abarth-chromium, 2014-01-06 22:34:02]

public/ changes LGTM

https://codereview.chromium.org/123133006/diff/1/public/web/WebFrame.h
File public/web/WebFrame.h (right):

https://codereview.chromium.org/123133006/diff/1/public/web/WebFrame.h#newcode43
public/web/WebFrame.h:43: #include "public/platform/WebURLRequest.h"
Unfortunately, this will cause some compile failures.  We want to fix those
build problems, but we don't need to block this CL on fixing them.

[davidben, 2014-01-06 22:42:49]

https://codereview.chromium.org/123133006/diff/1/public/web/WebFrame.h
File public/web/WebFrame.h (right):

https://codereview.chromium.org/123133006/diff/1/public/web/WebFrame.h#newcode43
public/web/WebFrame.h:43: #include "public/platform/WebURLRequest.h"
On 2014/01/06 22:34:02, abarth wrote:
> Unfortunately, this will cause some compile failures.  We want to fix those
> build problems, but we don't need to block this CL on fixing them.

That's what this is for. :-)

https://codereview.chromium.org/101203006/

I got everything building on my machine and sent out a try job with --sub_rep,
so hopefully that'll catch most of it.

[abarth-chromium, 2014-01-06 22:44:33]

Awesome, thank you!

[commit-bot: I haz the power, 2014-01-07 16:06:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/123133006/1

[commit-bot: I haz the power, 2014-01-07 16:12:50]

Change committed as 164592