Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 12313153: Add minimize button assets for panel windows. (Closed)

Created:
7 years, 9 months ago by flackr
Modified:
7 years, 9 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add minimize button assets for panel windows. BUG=172275 TEST=Open a panel window, minimize button next to close button has the minimize button asset. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M ash/resources/ash_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
A ash/resources/default_100_percent/common/window_minimize_short_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ash/resources/default_100_percent/common/window_minimize_short_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ash/resources/default_100_percent/common/window_minimize_short_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ash/resources/default_200_percent/common/window_minimize_short_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ash/resources/default_200_percent/common/window_minimize_short_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ash/resources/default_200_percent/common/window_minimize_short_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/wm/frame_painter.cc View 1 chunk +22 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
flackr
PTAL. This CL just adds minimize buttton resources and wires them up for windows which ...
7 years, 9 months ago (2013-02-27 21:33:25 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 9 months ago (2013-02-28 17:52:26 UTC) #2
flackr
7 years, 9 months ago (2013-03-01 13:27:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r185534 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698