Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 12313150: Assign color=0 in GrDrawState.cpp to stop tools from raising false alarms about uninit reads. (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Assign color=0 in GrDrawState.cpp to stop tools from raising false alarms about uninit reads. We were assigning color to oldColor but it in turn would never be read because the valid flags would be cleared. R=jvanverth@google.com Committed: https://code.google.com/p/skia/source/detail?r=7886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/gpu/GrDrawState.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
7 years, 9 months ago (2013-02-27 17:32:00 UTC) #1
jvanverth1
On 2013/02/27 17:32:00, bsalomon wrote: LGTM
7 years, 9 months ago (2013-02-27 17:36:36 UTC) #2
bsalomon
7 years, 9 months ago (2013-02-27 18:43:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r7886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698