Issue 12313149: Note avatar icon is shown mirrored in tab strip on Mac/Retina

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12313149: Note avatar icon is shown mirrored in tab strip on Mac/Retina (Closed)

Created:
7 years, 9 months ago by Takashi Toyoshima

Modified:
7 years, 9 months ago

Reviewers:
sail

CC:
chromium-reviews, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Note avatar icon is shown mirrored in tab strip on Mac/Retina Avatar icons for Mac is mirrored because they appear at the other end. But note icon is special because it has polarity. It should not be mirrored. In 100% images, Chrome already use the same image for the both platform. But, in 200% images, the icon is mistakenly mirrored. BUG=178397 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185089

Patch Set 1 #

Patch Set 2 : fixed #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	M	chrome/app/theme/default_200_percent/profile_avatar_note_mac.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

Hi sail, This change fix the problem. I just copy profile_avatar_note.png to profile_avatar_note_mac.png in default_200_percent/common ...

7 years, 9 months ago (2013-02-27 19:08:10 UTC) #1

Takashi Toyoshima

7 years, 9 months ago (2013-02-28 01:14:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r185089 (presubmit successful).

Expand Messages | Collapse Messages