Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8759)

Unified Diff: chrome/renderer/resources/extensions/declarative_content_custom_bindings.js

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/declarative_content_custom_bindings.js
===================================================================
--- chrome/renderer/resources/extensions/declarative_content_custom_bindings.js (revision 184858)
+++ chrome/renderer/resources/extensions/declarative_content_custom_bindings.js (working copy)
@@ -2,21 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Custom binding for the declarativeContent API.
+// Custom bindings for the declarativeContent API.
-var binding = require('binding').Binding.create('declarativeContent');
-
+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
var utils = require('utils');
var validate = require('schemaUtils').validate;
-binding.registerCustomHook( function(api) {
- var declarativeContent = api.compiledApi;
-
+chromeHidden.registerCustomHook('declarativeContent', function(api) {
// Returns the schema definition of type |typeId| defined in |namespace|.
- function getSchema(typeId) {
- return utils.lookup(api.schema.types,
- 'id',
- 'declarativeContent.' + typeId);
+ function getSchema(namespace, typeId) {
+ var apiSchema = utils.lookup(api.apiDefinitions, 'namespace', namespace);
+ var resultSchema = utils.lookup(
+ apiSchema.types, 'id', namespace + '.' + typeId);
+ return resultSchema;
}
// Helper function for the constructor of concrete datatypes of the
@@ -31,17 +29,15 @@
}
}
instance.instanceType = 'declarativeContent.' + typeId;
- var schema = getSchema(typeId);
+ var schema = getSchema('declarativeContent', typeId);
validate([instance], [schema]);
}
// Setup all data types for the declarative content API.
- declarativeContent.PageStateMatcher = function(parameters) {
+ chrome.declarativeContent.PageStateMatcher = function(parameters) {
setupInstance(this, parameters, 'PageStateMatcher');
};
- declarativeContent.ShowPageAction = function(parameters) {
+ chrome.declarativeContent.ShowPageAction = function(parameters) {
setupInstance(this, parameters, 'ShowPageAction');
};
});
-
-exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698