Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_helper.cc
===================================================================
--- chrome/renderer/extensions/extension_helper.cc (revision 184858)
+++ chrome/renderer/extensions/extension_helper.cc (working copy)
@@ -509,7 +509,8 @@
if (current_size > kMaxIconSize - actual_icon_size) {
AddMessageToRootConsole(
content::CONSOLE_MESSAGE_LEVEL_ERROR,
- "Icons are too large. Maximum total size for app icons is 128 KB.");
+ ASCIIToUTF16("Icons are too large. "
+ "Maximum total size for app icons is 128 KB."));
return;
}
actual_icon_size += current_size;
@@ -521,11 +522,6 @@
}
void ExtensionHelper::AddMessageToRootConsole(ConsoleMessageLevel level,
- const std::string& message) {
- AddMessageToRootConsole(level, ASCIIToUTF16(message));
-}
-
-void ExtensionHelper::AddMessageToRootConsole(ConsoleMessageLevel level,
const string16& message) {
if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
WebConsoleMessage::Level target_level = WebConsoleMessage::LevelLog;
« no previous file with comments | « chrome/renderer/extensions/extension_helper.h ('k') | chrome/renderer/extensions/file_browser_handler_custom_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698