Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: chrome/renderer/resources/extensions/i18n_custom_bindings.js

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the i18n API. 5 // Custom bindings for the i18n API.
6
7 var binding = require('binding').Binding.create('i18n');
8 6
9 var i18nNatives = requireNative('i18n'); 7 var i18nNatives = requireNative('i18n');
10 var GetL10nMessage = i18nNatives.GetL10nMessage; 8 var GetL10nMessage = i18nNatives.GetL10nMessage;
11 9
12 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden(); 10 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
13 11
14 binding.registerCustomHook(function(bindingsAPI, extensionId) { 12 chromeHidden.registerCustomHook('i18n', function(bindingsAPI, extensionId) {
15 var apiFunctions = bindingsAPI.apiFunctions; 13 var apiFunctions = bindingsAPI.apiFunctions;
16 14
17 apiFunctions.setUpdateArgumentsPreValidate('getMessage', function() { 15 apiFunctions.setUpdateArgumentsPreValidate('getMessage', function() {
18 var args = Array.prototype.slice.call(arguments); 16 var args = Array.prototype.slice.call(arguments);
19 17
20 // The first argument is the message, and should be a string. 18 // The first argument is the message, and should be a string.
21 var message = args[0]; 19 var message = args[0];
22 if (typeof(message) !== 'string') { 20 if (typeof(message) !== 'string') {
23 console.warn(extensionId + ': the first argument to getMessage should ' + 21 console.warn(extensionId + ': the first argument to getMessage should ' +
24 'be type "string", was ' + message + 22 'be type "string", was ' + message +
25 ' (type "' + typeof(message) + '")'); 23 ' (type "' + typeof(message) + '")');
26 args[0] = String(message); 24 args[0] = String(message);
27 } 25 }
28 26
29 return args; 27 return args;
30 }); 28 });
31 29
32 apiFunctions.setHandleRequest('getMessage', 30 apiFunctions.setHandleRequest('getMessage',
33 function(messageName, substitutions) { 31 function(messageName, substitutions) {
34 return GetL10nMessage(messageName, substitutions, extensionId); 32 return GetL10nMessage(messageName, substitutions, extensionId);
35 }); 33 });
36 }); 34 });
37
38 exports.binding = binding.generate();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698