Shrinking of PagedSpace is done only by sweeper.

Shrinking of PagedSpace is done only by sweeper.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13758

[Michael Starzinger, 2013-02-26 18:19:54]

https://codereview.chromium.org/12313131/diff/1/src/heap.cc
File src/heap.cc (left):

https://codereview.chromium.org/12313131/diff/1/src/heap.cc#oldcode796
src/heap.cc:796: // Committing memory to from space failed again.
s/failed again/failed/

https://codereview.chromium.org/12313131/diff/1/src/heap.cc#oldcode6423
src/heap.cc:6423: space->ReleaseAllUnusedPages();
The PagedSpace::ReleaseAllUnusedPages() is no longer called either. Also remove
that one.

[Hannes Payer (out of office), 2013-02-27 10:15:29]

https://codereview.chromium.org/12313131/diff/1/src/heap.cc
File src/heap.cc (left):

https://codereview.chromium.org/12313131/diff/1/src/heap.cc#oldcode796
src/heap.cc:796: // Committing memory to from space failed again.
On 2013/02/26 18:19:54, Michael Starzinger wrote:
> s/failed again/failed/

Done.

https://codereview.chromium.org/12313131/diff/1/src/heap.cc#oldcode6423
src/heap.cc:6423: space->ReleaseAllUnusedPages();
On 2013/02/26 18:19:54, Michael Starzinger wrote:
> The PagedSpace::ReleaseAllUnusedPages() is no longer called either. Also
remove
> that one.

Done.

[Michael Starzinger, 2013-02-27 12:29:07]

LGTM. As discussed offline: This should be OK even for the last-resort GC as we
are running a fix-point iteration there anyways which will cause us to wait for
the sweeper to finish.

One nit: Can we also remove the declaration of Heap::Shrink() in the heap.h
file?

[Hannes Payer (out of office), 2013-02-27 12:59:34]

Done.

[Hannes Payer (out of office), 2013-02-27 12:59:57]

Committed manually as r13758 (presubmit successful).