ui/compositor/layer_animation_element.cc - Issue 12313118: Refactor: Shelf Widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/compositor/layer_animation_element.cc

Issue 12313118: Refactor: Shelf Widget (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: formatting and moved a couple unit tests Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/compositor/layer_animation_element.cc

diff --git a/ui/compositor/layer_animation_element.cc b/ui/compositor/layer_animation_element.cc

index 81aeca59504d2974067431dcd840bd61bcb0e0b2..06a365ba1f25163b25291da556585728361c9178 100644

--- a/ui/compositor/layer_animation_element.cc

+++ b/ui/compositor/layer_animation_element.cc

@@ -553,7 +553,7 @@ bool LayerAnimationElement::Progress(base::TimeTicks now,

base::TimeDelta elapsed = now - effective_start_time_;

if ((duration_ > base::TimeDelta()) && (elapsed < duration_))

- t = elapsed.InMillisecondsF() / duration_.InMillisecondsF();

+ t = std::max(0.0, elapsed.InMillisecondsF() / duration_.InMillisecondsF());

Harry McCleave 2013/02/27 04:05:38 This is temporary and vollick@ is landing a patch

need_draw = OnProgress(Tween::CalculateValue(tween_type_, t), delegate);

first_frame_ = t == 1.0;

last_progressed_fraction_ = t;