Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: ash/launcher/launcher_view_unittest.cc

Issue 12313118: Refactor: Shelf Widget (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/launcher/launcher_view_unittest.cc
diff --git a/ash/launcher/launcher_view_unittest.cc b/ash/launcher/launcher_view_unittest.cc
index d3fd1ec4fd603d24824e96cc1704e88cf2f955d6..13f7fc87602b9c673cb8ad11abcc3ff7d0f18f45 100644
--- a/ash/launcher/launcher_view_unittest.cc
+++ b/ash/launcher/launcher_view_unittest.cc
@@ -13,6 +13,7 @@
#include "ash/launcher/launcher_model.h"
#include "ash/launcher/launcher_tooltip_manager.h"
#include "ash/root_window_controller.h"
+#include "ash/shelf/shelf_widget.h"
#include "ash/shell.h"
#include "ash/shell_window_ids.h"
#include "ash/test/ash_test_base.h"
@@ -174,12 +175,14 @@ TEST_F(LauncherViewIconObserverTest, MAYBE_AddRemoveWithMultipleDisplays) {
}
TEST_F(LauncherViewIconObserverTest, BoundsChanged) {
+ ShelfWidget* shelf = Shell::GetPrimaryRootWindowController()->shelf();
Launcher* launcher = Launcher::ForPrimaryDisplay();
- gfx::Size launcher_size =
- launcher->widget()->GetWindowBoundsInScreen().size();
- int total_width = launcher_size.width() / 2;
+ gfx::Size shelf_size =
+ shelf->GetWindowBoundsInScreen().size();
+ int total_width = shelf_size.width() / 2;
ASSERT_GT(total_width, 0);
- launcher->SetStatusSize(gfx::Size(total_width, launcher_size.height()));
+ launcher->SetLauncherViewBounds(
+ gfx::Rect(0, 0, total_width, shelf_size.height()));
Mr4D (OOO till 08-26) 2013/03/04 19:18:04 I would do it like this: shelf_size.set_width(..);
Harry McCleave 2013/03/04 20:29:24 Done.
// No animation happens for LauncherView bounds change.
EXPECT_TRUE(observer()->change_notified());
observer()->Reset();

Powered by Google App Engine
This is Rietveld 408576698