Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: chrome/test/data/extensions/api_test/notifications/galore/app/controller.js

Issue 12313115: Take notification API out of experimental. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missed one pathname. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
diff --git a/chrome/test/data/extensions/api_test/notification/galore/app/controller.js b/chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
similarity index 91%
rename from chrome/test/data/extensions/api_test/notification/galore/app/controller.js
rename to chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
index 3a4d95cb5708a36c9d1aceb3c9dcde3020122838..9f22cbe8c707522c5bfd883a2fb70db8ef5f593d 100644
--- a/chrome/test/data/extensions/api_test/notification/galore/app/controller.js
+++ b/chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
@@ -25,7 +25,7 @@ Galore.controller = {
/** @private */
listen_: function(event) {
var listener = this.event_.bind(this, event);
- chrome.experimental.notification[event].addListener(listener);
+ chrome.notification[event].addListener(listener);
dharcourt 2013/03/04 23:46:27 "chrome.notification*" should be "chrome.notificat
},
/** @private */
@@ -52,15 +52,15 @@ Galore.controller = {
var id = this.id_();
var priority = this.view.getPriority();
var expanded = this.expand_(options, type, priority);
- if (chrome.experimental.notification.create) {
- chrome.experimental.notification.create(id, expanded, function() {});
+ if (chrome.notification.create) {
+ chrome.notification.create(id, expanded, function() {});
} else {
expanded.replaceId = id;
delete expanded.buttonOneIconUrl;
delete expanded.buttonOneTitle;
delete expanded.buttonTwoIconUrl;
delete expanded.buttonTwoTitle;
- chrome.experimental.notification.show(expanded, function() {});
+ chrome.notification.show(expanded, function() {});
}
this.event_('create', id, 'priority: ' + priority);
},

Powered by Google App Engine
This is Rietveld 408576698