Take notification API out of experimental.

Take notification API out of experimental. Restrict to dev channel.

TBR=sky@chromium.org, yoz@chromium.org

BUG=178511
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186744

[miket_OOO, 2013-03-04 20:09:45]

This will be a difficult review. I'm sorry about that. I usually prefer to move
and alter in separate CLs, but various rules about our system prohibit that.

High-order bits:

  - Took Notification API out of experimental.

  - Changed name to "notifications" rather than "notification" to match our
naming system. This introduces a permission overlap with WebKit notifications,
which already took that permission name. I think this is acceptable; they both
represent the same concept.

  - Did a custom check that the APIs are being called only on dev/canary by a
platform_app or extension. This was necessary, again, because WK notifications
are already there, so _permission_features.json (which permit WK notifications
on all channels and all extension types) can't be changed.

  - Wrote new tests to check that the API is available only in dev/canary. This
isn't a perfect test (as it only tests the helper method, not the entire
end-to-end operation), but it's not currently possible to launch a browser test
in a certain release channel, and this CL wasn't the right place to add that
functionality.

  - There should be no other functional changes to this code.

[dharcourt, 2013-03-04 23:46:26]

Apart from [...]/google_now/background.js and [...]/galore/app/controller.js
where "chrome.notification" should be "chrome.notificiations" (plural), from a
"data"-became-"xdata" typo in api_test/notifications/galore/app/controller.js,
and from a few nits, LGTM.

In addition to nits mentioned in comments, the following files left over after
the change should be removed if they're not used by anything else (and it
doesn't seem they are):
chrome/test/data/extensions/api_test/notification/api/by_user.

https://codereview.chromium.org/12313115/diff/23012/chrome/browser/extensions...
File chrome/browser/extensions/api/notifications/notifications_api.cc (right):

https://codereview.chromium.org/12313115/diff/23012/chrome/browser/extensions...
chrome/browser/extensions/api/notifications/notifications_api.cc:122:
NotificationsApiFunction::MapApiTemplateTypeToType(
Nit: To match declaration order, the definition of IsNotificationsApiAvailable()
should be further down and the definition of IsNotificationsApiAvailable() 
should be before CreateNotification(). To make it closer to
IsNotificationsApiAvailable(), both the declaration and definition of
IsNotificationsApiEnabled() should be moved up to be just before
CreateNotification().

https://codereview.chromium.org/12313115/diff/23012/chrome/browser/extensions...
File chrome/browser/extensions/api/notifications/notifications_apitest.cc
(right):

https://codereview.chromium.org/12313115/diff/23012/chrome/browser/extensions...
chrome/browser/extensions/api/notifications/notifications_apitest.cc:227:
"\"message\": \"Multiple item notifications message.\","
Nit: Should be "Multiple item notification message."

https://codereview.chromium.org/12313115/diff/23012/chrome/browser/extensions...
File chrome/browser/extensions/event_names.cc (right):

https://codereview.chromium.org/12313115/diff/23012/chrome/browser/extensions...
chrome/browser/extensions/event_names.cc:97: "notification.onButtonClicked";
Nit: The wrap of the previous line isn't necessary any more.

https://codereview.chromium.org/12313115/diff/23012/chrome/browser/resources/...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/12313115/diff/23012/chrome/browser/resources/...
chrome/browser/resources/google_now/background.js:83:
chrome.notification.create(
"chrome.notification.*" should be "chrome.notifications.*" (plural) here and in
the rest of this file.

https://codereview.chromium.org/12313115/diff/23012/chrome/renderer/extension...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/12313115/diff/23012/chrome/renderer/extension...
chrome/renderer/extensions/dispatcher.cc:667:
IDR_NOTIFICATIONS_CUSTOM_BINDINGS_JS);
Nit: Move down to preserve alphabetical order.

https://codereview.chromium.org/12313115/diff/23012/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/notifications/api/csp/background.js
(right):

https://codereview.chromium.org/12313115/diff/23012/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/notifications/api/csp/background.js:132:
iconUrl: "xdata:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAA" +
"xdata" -> "data"?

https://codereview.chromium.org/12313115/diff/23012/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/notifications/galore/app/controller.js
(right):

https://codereview.chromium.org/12313115/diff/23012/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/notifications/galore/app/controller.js:28:
chrome.notification[event].addListener(listener);
"chrome.notification*" should be "chrome.notifications*" (plural) here and in
the rest of this file.

[commit-bot: I haz the power, 2013-03-07 01:04:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/12313115/54005

[commit-bot: I haz the power, 2013-03-07 01:05:01]

Can't process patch for file
chrome/test/data/extensions/api_test/notifications/galore/app/images/close-26x26.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[miket_OOO, 2013-03-07 18:22:31]

Committed patchset #3 manually as r186744 (presubmit successful).

[miket_OOO, 2013-03-07 22:00:34]

TBRs:

sky: *.gypi
yoz: I'm actually not sure what you're supposed to review that I'm not already
an OWNER for. Either chrome/browser/resources/google_now/background.js or just
disregard.