Host-side third party token validation

remoting/protocol/negotiating_authenticator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_NEGOTIATING_AUTHENTICATOR_H_
 #define REMOTING_PROTOCOL_NEGOTIATING_AUTHENTICATOR_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "remoting/protocol/authenticator.h"
 #include "remoting/protocol/authentication_method.h"
+#include "remoting/protocol/third_party_host_authenticator.h"
 
 namespace remoting {
 
 class RsaKeyPair;
 
 namespace protocol {
 
 typedef base::Callback<void(const std::string& secret)> SecretFetchedCallback;
 typedef base::Callback<void(
     const SecretFetchedCallback& secret_fetched_callback)> FetchSecretCallback;
@@ skipping 41 matching lines @@
  public:
   virtual ~NegotiatingAuthenticator();
 
   // Creates a client authenticator for the given methods.
   static scoped_ptr<Authenticator> CreateForClient(
       const std::string& authentication_tag,
       const FetchSecretCallback& fetch_secret_callback,
       const std::vector<AuthenticationMethod>& methods);
 
   // Creates a host authenticator, using a fixed shared secret/PIN hash.
-  static scoped_ptr<Authenticator> CreateForHost(
+  static scoped_ptr<Authenticator> CreateForHostSharedSecret(
       const std::string& local_cert,
       scoped_refptr<RsaKeyPair> key_pair,
       const std::string& shared_secret_hash,
       AuthenticationMethod::HashFunction hash_function);
 
+  // Creates a host authenticator, using third party authentication.
+  static scoped_ptr<Authenticator> CreateForHostThirdParty(
+      const std::string& local_cert,
+      scoped_refptr<RsaKeyPair> key_pair,
+      const std::string& local_jid,
+      const std::string& remote_jid,

[rmsousa, 2013/03/25 22:45:58]

Yeah, passing all these parameters 3-4 callstacks down is kind of annoying. I'll
move these to {SharedSecret,ThirdParty}HostAuthenticatorParams structs once the
question about the factory lifetime is settled.

+    scoped_refptr<ThirdPartyHostAuthenticator::TokenValidatorFactory>
+        token_validator_factory);
+
   // Authenticator interface.
   virtual State state() const OVERRIDE;
   virtual RejectionReason rejection_reason() const OVERRIDE;
   virtual void ProcessMessage(const buzz::XmlElement* message,
                               const base::Closure& resume_callback) OVERRIDE;
   virtual scoped_ptr<buzz::XmlElement> GetNextMessage() OVERRIDE;
   virtual scoped_ptr<ChannelAuthenticator>
       CreateChannelAuthenticator() const OVERRIDE;
 
  private:
@@ skipping 22 matching lines @@
   void CreateV2AuthenticatorWithSecret(
       Authenticator::State initial_state,
       const base::Closure& resume_callback,
       const std::string& shared_secret);
 
   bool is_host_side() const;
 
   // Used only for host authenticators.
   std::string local_cert_;
   scoped_refptr<RsaKeyPair> local_key_pair_;
+
+  // Used only for shared secret host authenticators.
   std::string shared_secret_hash_;
 
+  // Used only for third party host authenticators.
+  std::string local_jid_;
+  std::string remote_jid_;
+  scoped_refptr<ThirdPartyHostAuthenticator::TokenValidatorFactory>
+      token_validator_factory_;
+
   // Used only for client authenticators.
   std::string authentication_tag_;
   FetchSecretCallback fetch_secret_callback_;
 
   // Used for both host and client authenticators.
   std::vector<AuthenticationMethod> methods_;
   AuthenticationMethod current_method_;
   scoped_ptr<Authenticator> current_authenticator_;
   State state_;
   RejectionReason rejection_reason_;
 
   base::WeakPtrFactory<NegotiatingAuthenticator> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NegotiatingAuthenticator);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_NEGOTIATING_AUTHENTICATOR_H_