Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 12313012: Adding a histrogram to track account missmatch for signin reauth. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sync/signin_histogram.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 68430ce9b84184f148a026c2fe6224dc12631fc7..03ac9802ba089395641a7e7c2090c99f9cbbbf74 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -43,6 +43,7 @@
#include "chrome/browser/ui/sync/one_click_signin_histogram.h"
#include "chrome/browser/ui/sync/one_click_signin_infobar_delegate.h"
#include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
+#include "chrome/browser/ui/sync/signin_histogram.h"
#include "chrome/browser/ui/tab_modal_confirm_dialog.h"
#include "chrome/browser/ui/tab_modal_confirm_dialog_delegate.h"
#include "chrome/common/chrome_notification_types.h"
@@ -568,6 +569,9 @@ bool OneClickSigninHelper::CanOffer(content::WebContents* web_contents,
// Make sure this username is not prohibited by policy.
if (!manager->IsAllowedUsername(email)) {
+ UMA_HISTOGRAM_ENUMERATION("Signin.Reauth",
+ signin::HISTOGRAM_ACCOUNT_MISSMATCH,
+ signin::HISTOGRAM_MAX);
jwd 2013/02/20 22:41:27 Oh wow, this is totally wrong!
if (error_message) {
error_message->assign(
l10n_util::GetStringUTF8(IDS_SYNC_LOGIN_NAME_PROHIBITED));
« no previous file with comments | « no previous file | chrome/browser/ui/sync/signin_histogram.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698