Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1231273005: Access MediaKeyErrorCode from WebMediaPlayerEncryptedMediaClient (Closed)

Created:
5 years, 5 months ago by Srirama
Modified:
5 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Access MediaKeyErrorCode from WebMediaPlayerEncryptedMediaClient EncryptedMedia functionality has been moved from WebMediaPlayerClient to WebMediaPlayerEncryptedMediaClient, so access the MediaKeyErrorCode using WebMediaPlayerEncryptedMediaClient BUG=350571, 310466 Committed: https://crrev.com/04343bd4f9862530e0df7ecc86ef1249fa9c4c9e Cr-Commit-Position: refs/heads/master@{#338850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Srirama
PTAL. This is required to fix android build issue in https://codereview.chromium.org/1055503002/
5 years, 5 months ago (2015-07-15 11:32:19 UTC) #2
philipj_slow
Non-owner LGTM, adding qinmin@ for owners review.
5 years, 5 months ago (2015-07-15 13:10:04 UTC) #4
qinmin
lgtm
5 years, 5 months ago (2015-07-15 14:02:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231273005/1
5 years, 5 months ago (2015-07-15 14:03:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 14:07:41 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 14:08:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04343bd4f9862530e0df7ecc86ef1249fa9c4c9e
Cr-Commit-Position: refs/heads/master@{#338850}

Powered by Google App Engine
This is Rietveld 408576698