Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 123113002: cc: Improve worker pool performance by using std:make_heap instead of std:priority_queue. (Closed)

Created:
6 years, 11 months ago by reveman
Modified:
6 years, 11 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Improve worker pool performance by using std:make_heap instead of std:priority_queue. This reduces the complexity of building a new "ready to run" queue in WorkerPool::SetTaskGraph() from O(N·log(N)) to O(N). This refactor is also useful for supporting shared worker threads as it makes it easy to reuse the compare function and maintain a heap of ready to run task namespaces. BUG=246546 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M cc/resources/worker_pool.cc View 9 chunks +30 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reveman
6 years, 11 months ago (2014-01-02 03:31:06 UTC) #1
vmpstr
lgtm, thanks!
6 years, 11 months ago (2014-01-02 05:09:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/123113002/1
6 years, 11 months ago (2014-01-02 05:28:38 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-02 23:23:08 UTC) #4
Message was sent while issue was closed.
Change committed as 242833

Powered by Google App Engine
This is Rietveld 408576698