Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1231103002: [Downloads] Prevent executable files from being opened automatically. (Closed)

Created:
5 years, 5 months ago by asanka
Modified:
5 years, 5 months ago
Reviewers:
CC:
benjhayden+dwatch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

[Downloads] Prevent executable files from being opened automatically. Users can accidentally mark executable or other dangerous file types for opening automatically upon download. This change prevents such file types from being considered for auto open. If the user already has any dangerous file types in the auto-open list, those entries will be ignored on new browser sessions. Any action that causes the persisted auto-open list to be updated will, as a side-effect, premanently remove any dangerous file types that were there. Currently the list of file types that are excluded from auto open is maintained by chrome/browser/download/download_extension.cc. BUG=461858 TEST=(1) Download an .exe (on Windows) or .swf file. (2) Verify that the "Always open files of this type" option is disabled. Review URL: https://codereview.chromium.org/1165893004 TBR=asanka@chromium.org Cr-Commit-Position: refs/heads/master@{#334677} (cherry picked from commit 39841e54180e2583dffa16fbbb9b99fd293821d0) Committed: https://chromium.googlesource.com/chromium/src/+/ea65713eae7ad5977b6af590eb45e9551ea1fb2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -138 lines) Patch
M chrome/browser/download/download_commands.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/download/download_extensions.h View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/browser/download/download_extensions.cc View 3 chunks +277 lines, -129 lines 0 comments Download
M chrome/browser/download/download_prefs.h View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 2 chunks +24 lines, -7 lines 0 comments Download
A chrome/browser/download/download_prefs_unittest.cc View 1 chunk +117 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
asanka
5 years, 5 months ago (2015-07-10 15:53:11 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea65713eae7ad5977b6af590eb45e9551ea1fb2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698