cc/delegated_renderer_layer_impl.cc - Issue 12310179: cc: Without valid frame, delegated renderer layer is not drawable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/delegated_renderer_layer_impl.cc

Issue 12310179: cc: Without valid frame, delegated renderer layer is not drawable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/delegated_renderer_layer_impl.cc

diff --git a/cc/delegated_renderer_layer_impl.cc b/cc/delegated_renderer_layer_impl.cc

index a8cdd549d1fbbe70d8165d28aa903c8e479606e9..a84ed6dece4952a236c49f2c9748b9638f0bab13 100644

--- a/cc/delegated_renderer_layer_impl.cc

+++ b/cc/delegated_renderer_layer_impl.cc

@@ -53,10 +53,7 @@ void DelegatedRendererLayerImpl::SetFrameData(

bool old_frame_is_empty = !old_root_pass;

gfx::RectF damage_in_layer;

piman 2013/02/27 20:51:03 nit: you can now move this and the setUpdateRect i

danakj 2013/02/27 20:53:45 Thanks! I've already uploaded another version with

- if (new_frame_is_empty) {

- if (!old_frame_is_empty)

- damage_in_layer = gfx::Rect(bounds());

- } else {

+ if (!new_frame_is_empty) {

DCHECK(!new_root_pass->output_rect.IsEmpty());

damage_in_layer = MathUtil::mapClippedRect(

DelegatedFrameToLayerSpaceTransform(new_root_pass->output_rect.size()),

« no previous file with comments | « cc/delegated_renderer_layer_impl.h ('k') | cc/layer_tree_host_unittest_delegated.cc » ('j') | no next file with comments »