Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 12310153: bookmarks: Remove bookmark loaded notification. (Closed)

Created:
7 years, 10 months ago by tfarina
Modified:
7 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

bookmarks: Remove bookmark loaded notification. We converted all the usages of NOTIFICATION_BOOKMARK_MODEL_LOADED to the BookmarkModelObserver equivalent, so we don't need to send it anymore. BUG=144783 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M chrome/browser/bookmarks/bookmark_model.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Please, take a look.
7 years, 10 months ago (2013-02-26 22:58:22 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-02-27 00:32:37 UTC) #2
tfarina
7 years, 9 months ago (2013-02-27 15:29:38 UTC) #3
Message was sent while issue was closed.
Committed manually as r184956 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698