sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 12310133: Fix for issue 8781: it is not ok to move a HTypeGuard, so mark it as "unpure".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 12310133: Fix for issue 8781: it is not ok to move a HTypeGuard, so mark it as "unpure". (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 19041)

+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)

@@ -1216,6 +1216,8 @@

bool isControlFlow() => true;

bool isJsStatement() => isEnabled;

bool canThrow() => isEnabled;

+ // A [HTypeGuard] cannot be moved anywhere in the graph.

kasperl 2013/02/26 17:36:48 I would add a newline before the comment and exten

ngeoffray 2013/02/27 08:06:54 Done.

+ bool isPure() => false;

accept(HVisitor visitor) => visitor.visitTypeGuard(this);

int typeCode() => HInstruction.TYPE_GUARD_TYPECODE;

« no previous file with comments | « no previous file | tests/language/field_increment_bailout_test.dart » ('j') | no next file with comments »