Issue 12310115: ui::ThreadedOpacityTransition::OnAbort should depend on tween_type()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12310115: ui::ThreadedOpacityTransition::OnAbort should depend on tween_type() (Closed)

Created:
7 years, 10 months ago by ajuma

Modified:
7 years, 9 months ago

Reviewers:
Ian Vollick

CC:
chromium-reviews, piman+watch_chromium.org, jonathan.backer

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

ui::ThreadedOpacityTransition::OnAbort should depend on tween_type() ui::ThreadedOpacityTransition::OnAbort currently ignores tween_type(), and hence effectively assumes tween_type() is LINEAR. BUG=164206 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184997

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
	M	ui/compositor/layer_animation_element.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	ui/compositor/layer_animation_element_unittest.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ian Vollick

On 2013/02/25 20:46:57, ajuma wrote: Yep, this looks like the only spot where we're ignoring ...

7 years, 9 months ago (2013-02-27 17:04:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12310115/1

7 years, 9 months ago (2013-02-27 17:08:14 UTC) #3

Message was sent while issue was closed.

Change committed as 184997

Expand Messages | Collapse Messages