DescriptionMerge 143640
> Stop starting animations when leaving a page
> https://bugs.webkit.org/show_bug.cgi?id=110257
>
> Reviewed by Stephen Chenney.
>
> Source/WebCore:
>
> SVGImage::resetAnimation() incorrectly started animations which could cause a crash
> when leaving the page. This patch fixes resetAnimation to only stop the animation,
> similar to BitmapImage::resetAnimation().
>
> Additionally, this patch removes an unneeded call to Document::updateStyleForAllDocuments()
> that was present in the animation loop. This makes the animation code more resistant to
> similar bugs in the future.
>
> Both of these changes are functionally covered with existing tests.
>
> Test: svg/animations/reset-animation-crash.html
>
> * svg/animation/SMILTimeContainer.cpp:
> (WebCore::SMILTimeContainer::updateAnimations):
> * svg/graphics/SVGImage.cpp:
> (WebCore::SVGImage::resetAnimation):
>
> LayoutTests:
>
> * svg/animations/reset-animation-crash-expected.html: Added.
> * svg/animations/reset-animation-crash.html: Added.
>
TBR=pdr@google.com
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143957
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|