Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 12310113: Merge 143640 (Closed)

Created:
7 years, 10 months ago by pdr.
Modified:
7 years, 10 months ago
Reviewers:
pdr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 143640 > Stop starting animations when leaving a page > https://bugs.webkit.org/show_bug.cgi?id=110257 > > Reviewed by Stephen Chenney. > > Source/WebCore: > > SVGImage::resetAnimation() incorrectly started animations which could cause a crash > when leaving the page. This patch fixes resetAnimation to only stop the animation, > similar to BitmapImage::resetAnimation(). > > Additionally, this patch removes an unneeded call to Document::updateStyleForAllDocuments() > that was present in the animation loop. This makes the animation code more resistant to > similar bugs in the future. > > Both of these changes are functionally covered with existing tests. > > Test: svg/animations/reset-animation-crash.html > > * svg/animation/SMILTimeContainer.cpp: > (WebCore::SMILTimeContainer::updateAnimations): > * svg/graphics/SVGImage.cpp: > (WebCore::SVGImage::resetAnimation): > > LayoutTests: > > * svg/animations/reset-animation-crash-expected.html: Added. > * svg/animations/reset-animation-crash.html: Added. > TBR=pdr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -0 lines) Patch
A + LayoutTests/svg/animations/reset-animation-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/animations/reset-animation-crash-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/svg/animation/SMILTimeContainer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/svg/graphics/SVGImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
pdr.
7 years, 10 months ago (2013-02-25 20:25:18 UTC) #1
pdr.
7 years, 10 months ago (2013-02-25 20:25:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143957.

Powered by Google App Engine
This is Rietveld 408576698