Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3315)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 12310103: Small cleanups in RegExp to avoid generating lots of code just because there is a try/catch in our … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/lib/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (revision 19035)
+++ sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (working copy)
@@ -90,6 +90,7 @@
HTypeList result = new HTypeList(node.inputs.length - 1);
for (int i = 0; i < result.types.length; i++) {
result.types[i] = node.inputs[i + 1].instructionType;
+ assert(!result.types[i].isConflicting());
}
return result;
}
@@ -115,6 +116,7 @@
for (int i = 0; i < result.types.length; i++) {
result.types[i] = node.inputs[i + startInvokeIndex].instructionType;
+ assert(!result.types[i].isConflicting());
}
return result;
}
@@ -276,6 +278,7 @@
Element field,
HType type) {
assert(field.isField());
+ assert(!type.isConflicting());
HType before = optimisticFieldType(field);
HType oldType = typeMap[field];
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/lib/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698