Bluetooth: Add a "connectable" property to the BluetoothDevice.

chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/command_line.h"
@@ skipping 118 matching lines @@
     { "bluetoothConnectAuthFailed",
         IDS_OPTIONS_SETTINGS_BLUETOOTH_CONNECT_AUTH_FAILED },
     { "bluetoothConnectAuthCanceled",
         IDS_OPTIONS_SETTINGS_BLUETOOTH_CONNECT_AUTH_CANCELED },
     { "bluetoothConnectAuthRejected",
         IDS_OPTIONS_SETTINGS_BLUETOOTH_CONNECT_AUTH_REJECTED },
     { "bluetoothConnectAuthTimeout",
         IDS_OPTIONS_SETTINGS_BLUETOOTH_CONNECT_AUTH_TIMEOUT },
     { "bluetoothConnectUnsupportedDevice",
         IDS_OPTIONS_SETTINGS_BLUETOOTH_CONNECT_UNSUPPORTED_DEVICE },
+    { "bluetoothConnectSdpFailed",
+        IDS_OPTIONS_SETTINGS_BLUETOOTH_CONNECT_SDP_FAILED },
     { "bluetoothDisconnectFailed",
         IDS_OPTIONS_SETTINGS_BLUETOOTH_DISCONNECT_FAILED },
     { "bluetoothForgetFailed",
         IDS_OPTIONS_SETTINGS_BLUETOOTH_FORGET_FAILED }};
 
   RegisterStrings(localized_strings, resources, arraysize(resources));
 }
 
 // TODO(kevers): Reorder methods to match ordering in the header file.
 
@@ skipping 204 matching lines @@
       break;
     case device::BluetoothDevice::ERROR_AUTH_REJECTED:
       error_name = "bluetoothConnectAuthRejected";
       break;
     case device::BluetoothDevice::ERROR_AUTH_TIMEOUT:
       error_name = "bluetoothConnectAuthTimeout";
       break;
     case device::BluetoothDevice::ERROR_UNSUPPORTED_DEVICE:
       error_name = "bluetoothConnectUnsupportedDevice";
       break;
+    case device::BluetoothDevice::ERROR_SDP_FAILED:
+      error_name = "bluetoothConnectSdpFailed";

[Dan Beam, 2013/02/21 22:42:40]

what does SDP mean?

[deymo, 2013/02/22 23:09:09]

SDP = Service Discovery Protocol
BTW, I'll remove this error message in the UI level.

+      break;
   }
   // Report an error only if there's an error to report.
   if (error_name)
     ReportError(error_name, address);
 }
 
 void BluetoothOptionsHandler::DisconnectError(const std::string& address) {
   DVLOG(1) << "Failed to disconnect from device: " << address;
   ReportError("bluetoothDisconnectFailed", address);
 }
@@ skipping 30 matching lines @@
 
 void BluetoothOptionsHandler::SendDeviceNotification(
     const device::BluetoothDevice* device,
     base::DictionaryValue* params) {
   base::DictionaryValue js_properties;
   js_properties.SetString("name", device->GetName());
   js_properties.SetString("address", device->address());
   js_properties.SetBoolean("paired", device->IsPaired());
   js_properties.SetBoolean("bonded", device->IsBonded());
   js_properties.SetBoolean("connected", device->IsConnected());
+  js_properties.SetBoolean("connectable", device->IsConnectable());

[Dan Beam, 2013/02/21 22:42:40]

also, I have no idea what "connectable" means.

[deymo, 2013/02/22 23:09:09]

I chose the term "Connectable" from the "HIDNormallyConnectable" property name
from the Bluetooth HID spec. This property says if you can connect from the
adapter to the device when the device is not connected. This property is usually
false for mice and keyboards because they turn the radio off when on idle. After
all, those are only input devices, and if they have some events to send, they
will start the connection from the device to the adapter and send whatever they
need.
This property is important to the UI to (later) hide/disable the "Connect"
button for this kind of devices.

   if (params)
     js_properties.MergeDictionary(params);
   web_ui()->CallJavascriptFunction(
       "options.BrowserOptions.addBluetoothDevice",
       js_properties);
 }
 
 void BluetoothOptionsHandler::RequestPinCode(device::BluetoothDevice* device) {
   DictionaryValue params;
   params.SetString("pairing", kEnterPinCode);
@@ skipping 74 matching lines @@
 void BluetoothOptionsHandler::DeviceConnecting(
     device::BluetoothDevice* device) {
   DCHECK(device);
   DictionaryValue params;
   params.SetString("pairing", kStartConnecting);
   SendDeviceNotification(device, &params);
 }
 
 }  // namespace options
 }  // namespace chromeos