Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 12310045: Make quotes in support code match rest of code (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
index 19f6ce858066fedc9f16cca23b32db6bc8980113..c06de798eb4672538f0fe2a3fee8b01c7e621f2b 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
@@ -157,7 +157,7 @@ class Primitives {
// This is somewhat nasty, but we don't want to drag in a bunch of
// dependencies to handle a situation that cannot happen. So we
// avoid using Dart [:throw:] and Dart [toString].
- JS('void', "throw 'Unable to print message: ' + String(#)", string);
+ JS('void', 'throw "Unable to print message: " + String(#)', string);
}
static void _throwFormatException(String string) {
@@ -845,7 +845,7 @@ unwrapException(ex) {
// Check for the Firefox specific stack overflow signal.
if (JS('bool',
- r"typeof InternalError == 'function' && # instanceof InternalError",
+ r'typeof InternalError == "function" && # instanceof InternalError',
ex)) {
if (message is String && message == 'too much recursion') {
return new StackOverflowError();
@@ -1494,7 +1494,7 @@ String getRuntimeTypeString(var object) {
return "$className<${joinArguments(typeInfo, 0)}>";
}
-bool isJsFunction(var o) => JS('bool', r"typeof # == 'function'", o);
+bool isJsFunction(var o) => JS('bool', r'typeof # == "function"', o);
Object invoke(function, arguments) {
return JS('var', r'#.apply(null, #)', function, arguments);

Powered by Google App Engine
This is Rietveld 408576698