Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdch/sdch.gyp

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/serialized_handle.cc ('k') | webkit/browser/fileapi/sandbox_directory_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdch/sdch.gyp
diff --git a/sdch/sdch.gyp b/sdch/sdch.gyp
index 8d609d5d4a21967f82fe7768d2496f81ec0d72b8..99bcbd02ce86946dd8dee795c69c3db70778442c 100644
--- a/sdch/sdch.gyp
+++ b/sdch/sdch.gyp
@@ -58,8 +58,13 @@
[ 'OS == "ios"', { 'include_dirs': [ 'ios' ] } ],
[ 'OS == "mac"', { 'include_dirs': [ 'mac' ] } ],
[ 'OS == "win"', { 'include_dirs': [ 'open-vcdiff/vsprojects' ] } ],
- # TODO(mark): Remove usage of the deprecated auto_ptr.
- [ 'clang == 1', { 'cflags': [ '-Wno-deprecated-declarations' ] } ],
+ ['clang==1', {
+ # open-vcdiff uses intentional fallthroughs.
+ 'xcode_settings': { 'WARNING_CFLAGS!': [ '-Wimplicit-fallthrough' ] },
+ 'cflags!': [ '-Wimplicit-fallthrough' ],
+ # TODO(mark): Remove usage of the deprecated auto_ptr.
+ 'cflags': [ '-Wno-deprecated-declarations' ] }
+ }],
],
# open-vcdiff's logging.h introduces static initializers. This was
# reported upstream years ago (
« no previous file with comments | « ppapi/proxy/serialized_handle.cc ('k') | webkit/browser/fileapi/sandbox_directory_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698