Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: media/base/video_frame.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/gpu_info_collector_mac.mm ('k') | media/filters/gpu_video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_frame.cc
diff --git a/media/base/video_frame.cc b/media/base/video_frame.cc
index 8a4eb3cce2b62f57daa5f4ee6dcf961157806a16..1929563588730155977fffbee40df09ee2024b76 100644
--- a/media/base/video_frame.cc
+++ b/media/base/video_frame.cc
@@ -301,6 +301,7 @@ size_t VideoFrame::PlaneAllocationSize(Format format,
default:
break;
}
+ break;
}
case VideoFrame::YV12A: {
switch (plane) {
@@ -313,6 +314,7 @@ size_t VideoFrame::PlaneAllocationSize(Format format,
default:
break;
}
+ break;
}
case VideoFrame::YV16: {
switch (plane) {
@@ -324,6 +326,7 @@ size_t VideoFrame::PlaneAllocationSize(Format format,
default:
break;
}
+ break;
}
case VideoFrame::UNKNOWN:
case VideoFrame::NATIVE_TEXTURE:
@@ -438,7 +441,7 @@ int VideoFrame::row_bytes(size_t plane) const {
case YV12A:
if (plane == kAPlane)
return width;
- // Fallthrough.
+ FALLTHROUGH_INTENDED;
case YV12:
case YV16:
case I420:
@@ -466,7 +469,7 @@ int VideoFrame::rows(size_t plane) const {
case YV12A:
if (plane == kAPlane)
return height;
- // Fallthrough.
+ FALLTHROUGH_INTENDED;
case YV12:
case I420:
if (plane == kYPlane)
« no previous file with comments | « gpu/config/gpu_info_collector_mac.mm ('k') | media/filters/gpu_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698