Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2394)

Unified Diff: build/common.gypi

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/third_party/icu/icu_utf.cc ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index dd999251dbad7a0367cabd9752e680b9cb70153d..18e261d64641ff3a26ba80664aff491423690409 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2481,6 +2481,7 @@
'cflags!': [
'-Wall',
'-Wextra',
+ '-Wimplicit-fallthrough',
],
'cflags_cc': [
# Don't warn about hash_map in third-party code.
@@ -2542,7 +2543,7 @@
}],
[ 'OS=="mac" or OS=="ios"', {
'xcode_settings': {
- 'WARNING_CFLAGS!': ['-Wall', '-Wextra'],
+ 'WARNING_CFLAGS!': ['-Wall', '-Wextra', '-Wimplicit-fallthrough'],
},
'conditions': [
['buildtype=="Official"', {
@@ -3306,6 +3307,7 @@
['clang==1', {
'cflags': [
'-Wheader-hygiene',
+ '-Wimplicit-fallthrough',
# Don't die on dtoa code that uses a char as an array index.
'-Wno-char-subscripts',
@@ -4010,6 +4012,7 @@
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
'WARNING_CFLAGS': [
'-Wheader-hygiene',
+ '-Wimplicit-fallthrough',
# This warns on using ints as initializers for floats in
# initializer lists (e.g. |int a = f(); CGSize s = { a, a };|),
« no previous file with comments | « base/third_party/icu/icu_utf.cc ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698