Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Side by Side Diff: net/http/http_cache_transaction.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/dns/dns_config_service_posix.cc ('k') | net/http/http_pipelined_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_cache_transaction.h" 5 #include "net/http/http_cache_transaction.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 8
9 #if defined(OS_POSIX) 9 #if defined(OS_POSIX)
10 #include <unistd.h> 10 #include <unistd.h>
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 int rv; 415 int rv;
416 416
417 switch (mode_) { 417 switch (mode_) {
418 case READ_WRITE: 418 case READ_WRITE:
419 DCHECK(partial_.get()); 419 DCHECK(partial_.get());
420 if (!network_trans_.get()) { 420 if (!network_trans_.get()) {
421 // We are just reading from the cache, but we may be writing later. 421 // We are just reading from the cache, but we may be writing later.
422 rv = ReadFromEntry(buf, buf_len); 422 rv = ReadFromEntry(buf, buf_len);
423 break; 423 break;
424 } 424 }
425 FALLTHROUGH_INTENDED;
425 case NONE: 426 case NONE:
426 case WRITE: 427 case WRITE:
427 DCHECK(network_trans_.get()); 428 DCHECK(network_trans_.get());
428 rv = ReadFromNetwork(buf, buf_len); 429 rv = ReadFromNetwork(buf, buf_len);
429 break; 430 break;
430 case READ: 431 case READ:
431 rv = ReadFromEntry(buf, buf_len); 432 rv = ReadFromEntry(buf, buf_len);
432 break; 433 break;
433 default: 434 default:
434 NOTREACHED(); 435 NOTREACHED();
(...skipping 2100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2535 UMA_HISTOGRAM_PERCENTAGE("HttpCache.PercentBeforeSend.Updated", 2536 UMA_HISTOGRAM_PERCENTAGE("HttpCache.PercentBeforeSend.Updated",
2536 before_send_percent); 2537 before_send_percent);
2537 break; 2538 break;
2538 } 2539 }
2539 default: 2540 default:
2540 NOTREACHED(); 2541 NOTREACHED();
2541 } 2542 }
2542 } 2543 }
2543 2544
2544 } // namespace net 2545 } // namespace net
OLDNEW
« no previous file with comments | « net/dns/dns_config_service_posix.cc ('k') | net/http/http_pipelined_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698