Allow whitespace in version constraints.

utils/tests/pub/version_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library version_test;
 
 import '../../../pkg/unittest/lib/unittest.dart';
 import 'test_pub.dart';
 import '../../pub/utils.dart';
 import '../../pub/version.dart';
 
 main() {
+  initConfig();
+
   final v123 = new Version.parse('1.2.3');
   final v114 = new Version.parse('1.1.4');
   final v124 = new Version.parse('1.2.4');
   final v200 = new Version.parse('2.0.0');
   final v234 = new Version.parse('2.3.4');
   final v250 = new Version.parse('2.5.0');
   final v300 = new Version.parse('3.0.0');
 
   group('Version', () {
     test('none', () {
@@ skipping 356 matching lines @@
         var constraint = new VersionConstraint.parse('>1.0.0 >=1.2.3 <1.3.0');
         expect(constraint, allows([
             new Version.parse('1.2.3'),
             new Version.parse('1.2.5')]));
         expect(constraint, doesNotAllow([
             new Version.parse('1.2.3-pre'),
             new Version.parse('1.3.0'),
             new Version.parse('3.4.5')]));
       });
 
+      test('ignores whitespace around operators', () {
+        var constraint = new VersionConstraint.parse(' >1.0.0>=1.2.3 < 1.3.0');
+        expect(constraint, allows([
+            new Version.parse('1.2.3'),
+            new Version.parse('1.2.5')]));
+        expect(constraint, doesNotAllow([
+            new Version.parse('1.2.3-pre'),
+            new Version.parse('1.3.0'),
+            new Version.parse('3.4.5')]));
+      });
+
       test('throws FormatException on a bad string', () {
         expect(() => new VersionConstraint.parse(''), throwsFormatException);
         expect(() => new VersionConstraint.parse('   '), throwsFormatException);
-        expect(() => new VersionConstraint.parse('not a version'),
+        expect(() => new VersionConstraint.parse('1.0.0 what is this here'),
+            throwsFormatException);
+
+        // Multiple operators.
+        expect(() => new VersionConstraint.parse('<>1.0.0'),
+            throwsFormatException);
+
+        // "any" after operator.
+        expect(() => new VersionConstraint.parse('<any'),
+            throwsFormatException);
+
+        // Trailing operator.
+        expect(() => new VersionConstraint.parse('1.0.0<'),
             throwsFormatException);

[nweiz, 2013/02/21 01:31:11]

Other strings to test: "foo", "1.0.0foo", "anything".

[Bob Nystrom, 2013/02/21 20:00:50]

Done.

       });
     });
   });
 }
 
 class VersionConstraintMatcher implements Matcher {
   final List<Version> _expected;
   final bool _allow;
 
   VersionConstraintMatcher(this._expected, this._allow);
@@ skipping 35 matching lines @@
 
 Matcher allows(List<Version> versions) =>
     new VersionConstraintMatcher(versions, true);
 
 Matcher doesNotAllow(List<Version> versions) =>
     new VersionConstraintMatcher(versions, false);
 
 throwsIllegalArg(function) {
   expect(function, throwsA((e) => e is ArgumentError));
 }